Skip to content

[JitDiff X64] [EgorBo] Inline nullable allocators #1670

@MihuBot

Description

@MihuBot

Job completed in 16 minutes 4 seconds (remote runner delay: 1 minute 5 seconds).
dotnet/runtime#122167

Diffs

Diffs
Found 92 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45954520
Total bytes of diff: 45954199
Total bytes of delta: -321 (-0.00 % of base)
Total relative delta: -0.73
    diff is an improvement.
    relative diff is an improvement.


Top file regressions (bytes):
          12 : System.Collections.Immutable.dasm (0.00 % of base)
          11 : System.Text.Json.dasm (0.00 % of base)
           7 : System.Collections.dasm (0.00 % of base)

Top file improvements (bytes):
        -156 : System.Private.CoreLib.dasm (-0.00 % of base)
         -72 : System.Private.Xml.dasm (-0.00 % of base)
         -57 : System.IO.Ports.dasm (-0.11 % of base)
         -28 : System.IO.Packaging.dasm (-0.02 % of base)
         -20 : System.Diagnostics.FileVersionInfo.dasm (-0.19 % of base)
         -10 : System.Net.Http.dasm (-0.00 % of base)
          -8 : System.Private.DataContractSerialization.dasm (-0.00 % of base)

10 total files with Code Size differences (7 improved, 3 regressed), 250 unchanged.

Top method regressions (bytes):
          22 (1.82 % of base) : System.Private.CoreLib.dasm - System.Collections.ObjectModel.ReadOnlyDictionary`2[System.__Canon,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this (FullOpts)
          12 (0.65 % of base) : System.Collections.Immutable.dasm - System.Collections.Frozen.FrozenDictionary`2[System.__Canon,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this (FullOpts)
          11 (1.38 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter`1[System.Nullable`1[int]]:ReadCore(byref,byref,System.Text.Json.JsonSerializerOptions,byref):bool:this (FullOpts)
           7 (1.56 % of base) : System.Collections.dasm - System.Collections.Generic.OrderedDictionary`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
           7 (1.56 % of base) : System.Collections.dasm - System.Collections.Generic.OrderedDictionary`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IDictionary.set_Item(System.Object,System.Object):this (FullOpts)
           6 (0.73 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.Dictionary`2[System.__Canon,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this (FullOpts)
           5 (1.08 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[byte,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
           1 (0.23 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[int,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
           1 (0.21 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)

Top method improvements (bytes):
         -57 (-7.79 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_FreeBSD():System.String[] (FullOpts)
         -50 (-0.97 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):byte[] (FullOpts)
         -31 (-1.43 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceEnd(System.String,System.Type,System.Type):this (FullOpts)
         -23 (-0.95 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceBegin(System.String):this (FullOpts)
         -20 (-1.00 % of base) : System.Diagnostics.FileVersionInfo.dasm - System.Diagnostics.FileVersionInfo:LoadManagedAssemblyMetadata(System.Reflection.Metadata.MetadataReader,bool):this (FullOpts)
         -20 (-3.13 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.ActivityTracker:NormalizeActivityName(System.String,System.String,int):System.String (FullOpts)
         -18 (-4.74 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.CodeIdentifier:EscapeKeywords(System.String,System.Text.StringBuilder) (FullOpts)
         -16 (-13.79 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:GetOpcodeWithDefault(int,System.String):int (FullOpts)
         -10 (-1.45 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackUriHelper+ValidatedPartUri:IsRelationshipUri():bool:this (FullOpts)
         -10 (-1.06 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ZipPackagePartPiece:TryParseName(System.String,byref,byref,byref,byref):bool (FullOpts)
         -10 (-0.25 % of base) : System.Net.Http.dasm - System.Net.Http.AuthenticationHelper+<GetDigestTokenForCredential>d__40:MoveNext():this (FullOpts)
         -10 (-1.56 % of base) : System.Private.CoreLib.dasm - System.StartupHookProvider:ParseStartupHook(byref,System.String) (FullOpts)
         -10 (-5.35 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`1[System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.48 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[byte,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.45 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[double,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.55 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[int,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.51 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[long,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.47 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[short,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.53 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.17 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[System.Numerics.Vector`1[float],System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
          -9 (-2.12 % of base) : System.Collections.dasm - System.Collections.Generic.OrderedDictionary`2[int,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
          -8 (-3.31 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.DebugProvider:Write(System.String):this (FullOpts)
          -8 (-7.69 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ZipPackage:IsZipItemValidOpcPartOrPiece(System.String):bool (FullOpts)
          -8 (-0.75 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonReaderDelegator:ParseJsonDateInDefaultFormat(System.String):System.DateTime (FullOpts)
          -5 (-1.07 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[long,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)

Top method regressions (percentages):
          22 (1.82 % of base) : System.Private.CoreLib.dasm - System.Collections.ObjectModel.ReadOnlyDictionary`2[System.__Canon,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this (FullOpts)
           7 (1.56 % of base) : System.Collections.dasm - System.Collections.Generic.OrderedDictionary`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
           7 (1.56 % of base) : System.Collections.dasm - System.Collections.Generic.OrderedDictionary`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IDictionary.set_Item(System.Object,System.Object):this (FullOpts)
          11 (1.38 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter`1[System.Nullable`1[int]]:ReadCore(byref,byref,System.Text.Json.JsonSerializerOptions,byref):bool:this (FullOpts)
           5 (1.08 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[byte,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
           6 (0.73 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.Dictionary`2[System.__Canon,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this (FullOpts)
          12 (0.65 % of base) : System.Collections.Immutable.dasm - System.Collections.Frozen.FrozenDictionary`2[System.__Canon,System.Nullable`1[int]]:System.Collections.ICollection.CopyTo(System.Array,int):this (FullOpts)
           1 (0.23 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[int,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
           1 (0.21 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)

Top method improvements (percentages):
         -16 (-13.79 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:GetOpcodeWithDefault(int,System.String):int (FullOpts)
         -57 (-7.79 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_FreeBSD():System.String[] (FullOpts)
          -8 (-7.69 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ZipPackage:IsZipItemValidOpcPartOrPiece(System.String):bool (FullOpts)
         -10 (-5.35 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`1[System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -18 (-4.74 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.CodeIdentifier:EscapeKeywords(System.String,System.Text.StringBuilder) (FullOpts)
         -10 (-3.55 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[int,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.53 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[System.Nullable`1[int],System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.51 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[long,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.48 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[byte,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.47 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[short,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -10 (-3.45 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[double,System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
          -8 (-3.31 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.DebugProvider:Write(System.String):this (FullOpts)
         -10 (-3.17 % of base) : System.Private.CoreLib.dasm - System.ValueTuple`2[System.Numerics.Vector`1[float],System.Nullable`1[int]]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)
         -20 (-3.13 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.ActivityTracker:NormalizeActivityName(System.String,System.String,int):System.String (FullOpts)
          -9 (-2.12 % of base) : System.Collections.dasm - System.Collections.Generic.OrderedDictionary`2[int,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
         -10 (-1.56 % of base) : System.Private.CoreLib.dasm - System.StartupHookProvider:ParseStartupHook(byref,System.String) (FullOpts)
         -10 (-1.45 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackUriHelper+ValidatedPartUri:IsRelationshipUri():bool:this (FullOpts)
         -31 (-1.43 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceEnd(System.String,System.Type,System.Type):this (FullOpts)
          -5 (-1.07 % of base) : System.Collections.dasm - System.Collections.Generic.SortedList`2[long,System.Nullable`1[int]]:System.Collections.IDictionary.Add(System.Object,System.Object):this (FullOpts)
         -10 (-1.06 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ZipPackagePartPiece:TryParseName(System.String,byref,byref,byref,byref):bool (FullOpts)
         -20 (-1.00 % of base) : System.Diagnostics.FileVersionInfo.dasm - System.Diagnostics.FileVersionInfo:LoadManagedAssemblyMetadata(System.Reflection.Metadata.MetadataReader,bool):this (FullOpts)
         -50 (-0.97 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):byte[] (FullOpts)
         -23 (-0.95 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceBegin(System.String):this (FullOpts)
          -8 (-0.75 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonReaderDelegator:ParseJsonDateInDefaultFormat(System.String):System.DateTime (FullOpts)
         -10 (-0.25 % of base) : System.Net.Http.dasm - System.Net.Http.AuthenticationHelper+<GetDigestTokenForCredential>d__40:MoveNext():this (FullOpts)

34 total methods with Code Size differences (25 improved, 9 regressed), 283132 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions