Make all table operations async (issue #54)

Author: Duncan-at-Hedgefacts

src/EventSourcingOnAzureFunctions.Common/EventSourcing/Implementation/AzureStorage/Table/TableEventStreamBase.cs

@@ -126,14 +126,24 @@ public async Task<bool> Exists()
         /// <remarks>
         /// We use the existence of the stream footer record as proof of stream existence
         /// </remarks>
-        protected internal bool StreamAlreadyExists()
+        protected async internal Task<bool> StreamAlreadyExists()
         {
             TableEntityKeyRecord streamFooter = null;
 
-            streamFooter = (TableEntityKeyRecord)Table.Execute(
-                   TableOperation.Retrieve<TableEntityKeyRecord>(this.InstanceKey, SequenceNumberAsString(0)),
-                   requestOptions: null,
-                   operationContext: GetDefaultOperationContext()).Result;
+            TableOperation getKeyRecord = TableOperation.Retrieve<TableEntityKeyRecord>(this.InstanceKey, SequenceNumberAsString(0));
+
+
+            TableResult getFooter = await Table.ExecuteAsync(
+                getKeyRecord);
+
+            if (getFooter != null)
+            {
+                if (getFooter.Result != null)
+                {
+                    streamFooter = (TableEntityKeyRecord)getFooter.Result;
+                }
+            }
+
 
             if (null != streamFooter)
             {

src/EventSourcingOnAzureFunctions.Common/EventSourcing/Implementation/AzureStorage/Table/TableEventStreamWriter.cs

@@ -14,7 +14,22 @@ public sealed class TableEventStreamWriter
         : TableEventStreamBase, IEventStreamWriter
     {
 
-
+        /// <summary>
+        /// Save an event onto the end of the event stream stored in Azure table
+        /// </summary>
+        /// <param name="eventInstance">
+        /// The specific event to append to the end of the store
+        /// </param>
+        /// <param name="expectedTopSequenceNumber">
+        /// If this is set and the sequence number of the event stream is higher then the event is 
+        /// not written
+        /// </param>
+        /// <param name="eventVersionNumber">
+        /// The version number of the event being written
+        /// </param>
+        /// <param name="streamConstraint">
+        /// Additional constraint that must be true if the event is to be appended
+        /// </param>
         public async Task<IAppendResult> AppendEvent(IEvent eventInstance,
             int expectedTopSequenceNumber = 0,
             int eventVersionNumber = 1,
@@ -27,7 +42,7 @@ public async Task<IAppendResult> AppendEvent(IEvent eventInstance,
             if (streamConstraint != EventStreamExistenceConstraint.Loose )
             {
                 // find out if the stream exists
-                bool exists = StreamAlreadyExists();
+                bool exists = await StreamAlreadyExists();
                 if (streamConstraint== EventStreamExistenceConstraint.MustExist )
                 {
                     if (! exists )
@@ -108,10 +123,19 @@ private async Task<int> IncrementSequenceNumber()
             {
                 tries += 1;
                 // read in the a [TableEntityKeyRecord]
+                TableOperation getKeyRecord = TableOperation.Retrieve<TableEntityKeyRecord>(this.InstanceKey, SequenceNumberAsString(0));
+
 
-                streamFooter = (TableEntityKeyRecord)Table.Execute(
-                    TableOperation.Retrieve<TableEntityKeyRecord>(this.InstanceKey, SequenceNumberAsString(0)),
-                    operationContext: GetDefaultOperationContext()).Result;
+                TableResult getFooter =  await Table.ExecuteAsync(
+                    getKeyRecord );
+
+                if (getFooter != null)
+                {
+                    if (getFooter.Result != null)
+                    {
+                        streamFooter = (TableEntityKeyRecord)getFooter.Result;
+                    }
+                }
 
                 if (null == streamFooter)
                 {
@@ -198,10 +222,19 @@ public async Task  DeleteStream()
             {
                 tries += 1;
                 // read in the a [TableEntityKeyRecord]
+                TableOperation getKeyRecord = TableOperation.Retrieve<TableEntityKeyRecord>(this.InstanceKey, SequenceNumberAsString(0));
+
+
+                TableResult getFooter = await Table.ExecuteAsync(
+                    getKeyRecord);
 
-                streamFooter = (TableEntityKeyRecord)Table.Execute(
-                    TableOperation.Retrieve<TableEntityKeyRecord>(this.InstanceKey, SequenceNumberAsString(0)),
-                    operationContext: GetDefaultOperationContext()).Result;
+                if (getFooter != null)
+                {
+                    if (getFooter.Result != null)
+                    {
+                        streamFooter = (TableEntityKeyRecord)getFooter.Result;
+                    }
+                }
 
                 if (null == streamFooter)
                 {

src/EventSourcingOnAzureFunctions.Common/EventSourcingOnAzureFunctions.Common.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
     <PackageId>EventSourcingOnAzureFunctions.Common</PackageId>
-    <PackageVersion>1.1</PackageVersion>
+    <PackageVersion>1.2</PackageVersion>
     <LangVersion>7.1</LangVersion>
     <Authors>Duncan Jones</Authors>
     <Description>Common function library to provide for event sourcing backed state management in Azure serverless functions</Description>
@@ -13,7 +13,7 @@
     <PackageTags>Event sourcing,serverless,azure functions</PackageTags>
     <Platforms>AnyCPU;x64</Platforms>
     <AssemblyVersion>1.1.0.0</AssemblyVersion>
-    <Version>1.1</Version>
+    <Version>1.2</Version>
     <IsPackable>true</IsPackable>
     <PackageReleaseNotes>Added notifications (via EventGrid) and CQRS scaffold</PackageReleaseNotes>
     <Copyright>2017-2021 Duncan Jones</Copyright>

src/EventSourcingOnAzureFunctions.Common/Notification/EventGridNotificationDispatcher.cs

@@ -591,17 +591,14 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
         }
 
         /// <summary>
-        /// Make a string that can be passed to the W3C Trace header as a trace paren
+        /// Make a string that can be passed to the W3C Trace header as a trace parent
         /// </summary>
         /// <param name="correlationIdentifier">
         /// The string we used as our correlation identifier 
         /// </param>
         /// <param name="causationIdentifier">
         /// The string we used as our causation identifier
         /// </param>
-        /// <returns>
-        /// 
-        /// </returns>
         /// <remarks>
         /// See https://www.w3.org/TR/trace-context/#examples-of-http-traceparent-headers
         /// </remarks>