Skip to content

Commit 3193495

Browse files
MatthieeMatthiee
authored
Use MinVer for Nuget Package versioning (#44)
* Add MinVer * Use MinVer to generate correct package versions fixes #42 * Bump fetch v3 * Use correct symbol
1 parent 72e51c6 commit 3193495

File tree

4 files changed

+62
-42
lines changed

4 files changed

+62
-42
lines changed

‎.github/workflows/dotnet.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ jobs:
1212
runs-on: ubuntu-latest
1313

1414
steps:
15-
- uses: actions/checkout@v2
15+
- uses: actions/checkout@v3
16+
with:
17+
fetch-depth: 0
1618
- name: Setup .NET
1719
uses: actions/setup-dotnet@v1
1820
with:

‎FinancialModelingPrepApi/FinancialModelingPrepApi.csproj‎

Lines changed: 48 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,54 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<PropertyGroup>
4-
<TargetFramework>net5.0</TargetFramework>
5-
<RootNamespace>MatthiWare.FinancialModelingPrep</RootNamespace>
6-
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
7-
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
8-
<AssemblyVersion>0.1.12.0</AssemblyVersion>
9-
<FileVersion>0.1.12.0</FileVersion>
10-
<Company>MatthiWare</Company>
11-
<PackageId>MatthiWare.FinancialModelingPrep</PackageId>
12-
<Version>0.1.12</Version>
13-
<Description>FinancialModelingPrep API Client written in .NET 5</Description>
14-
<Copyright>Copyright Matthias Beerens 2021</Copyright>
15-
<Product>FinancialModelingPrep API Client</Product>
16-
<Authors>Matthias Beerens</Authors>
17-
<PackageLicenseFile>LICENSE</PackageLicenseFile>
18-
<RepositoryUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</RepositoryUrl>
19-
<RepositoryType>git</RepositoryType>
20-
<PackageTags>FinancialModelingPrep stock quote finance-api</PackageTags>
21-
<PackageProjectUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</PackageProjectUrl>
22-
<PackageReleaseNotes>
23-
- GetEnterpriseValueAsync Type fixed
24-
</PackageReleaseNotes>
25-
<AssemblyName>FinancialModelingPrep</AssemblyName>
26-
</PropertyGroup>
3+
<PropertyGroup>
4+
<TargetFramework>net5.0</TargetFramework>
5+
<RootNamespace>MatthiWare.FinancialModelingPrep</RootNamespace>
6+
<PackageRequireLicenseAcceptance>False</PackageRequireLicenseAcceptance>
7+
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
8+
<Company>MatthiWare</Company>
9+
<PackageId>MatthiWare.FinancialModelingPrep</PackageId>
10+
<Description>FinancialModelingPrep API Client written in .NET 5</Description>
11+
<Copyright>Copyright Matthias Beerens 2021</Copyright>
12+
<Product>FinancialModelingPrep API Client</Product>
13+
<Authors>Matthias Beerens</Authors>
14+
<PackageLicenseFile>LICENSE</PackageLicenseFile>
15+
<RepositoryUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</RepositoryUrl>
16+
<RepositoryType>git</RepositoryType>
17+
<PackageTags>FinancialModelingPrep stock quote finance-api</PackageTags>
18+
<PackageProjectUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</PackageProjectUrl>
19+
<PackageReleaseNotes>
20+
- GetEnterpriseValueAsync Type fixed
21+
</PackageReleaseNotes>
22+
<AssemblyName>FinancialModelingPrep</AssemblyName>
23+
</PropertyGroup>
2724

28-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
29-
<DocumentationFile>D:\Source\Repos\FinancialModelingPrep.NET\FinancialModelingPrepApi\FinancialModelingPrepApi.xml</DocumentationFile>
30-
</PropertyGroup>
25+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
26+
<DocumentationFile>D:\Source\Repos\FinancialModelingPrep.NET\FinancialModelingPrepApi\FinancialModelingPrepApi.xml</DocumentationFile>
27+
</PropertyGroup>
3128

32-
<ItemGroup>
33-
<PackageReference Include="Bert.RateLimiters" Version="1.0.15" />
34-
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0" />
35-
<PackageReference Include="Microsoft.Extensions.Http" Version="6.0.0" />
36-
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" />
37-
</ItemGroup>
29+
<ItemGroup>
30+
<PackageReference Include="Bert.RateLimiters" Version="1.0.15" />
31+
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0" />
32+
<PackageReference Include="Microsoft.Extensions.Http" Version="6.0.0" />
33+
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" />
34+
<PackageReference Include="MinVer" Version="4.1.0">
35+
<PrivateAssets>all</PrivateAssets>
36+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
37+
</PackageReference>
38+
</ItemGroup>
3839

39-
<ItemGroup>
40-
<None Include="..\LICENSE">
41-
<Pack>True</Pack>
42-
<PackagePath></PackagePath>
43-
</None>
44-
</ItemGroup>
40+
<PropertyGroup>
41+
<MinVerSkip Condition="'$(Configuration)|$(Platform)'=='Debug'">true</MinVerSkip>
42+
<MinVerTagPrefix>v</MinVerTagPrefix>
43+
<MinVerIgnoreHeight>true</MinVerIgnoreHeight>
44+
<MinVerVerbosity>normal</MinVerVerbosity>
45+
</PropertyGroup>
46+
47+
<ItemGroup>
48+
<None Include="..\LICENSE">
49+
<Pack>True</Pack>
50+
<PackagePath></PackagePath>
51+
</None>
52+
</ItemGroup>
4553

4654
</Project>

‎FinancialModelingPrepApi/FinancialModelingPrepApi.xml‎

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Tests/CompanyValuation/CompanyValuationTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ public async Task GetCompanyKeyMetricsTTMAsync(string symbol)
302302
[InlineData("AGS.BR", Period.Annual)]
303303
[InlineData("CMCSA", Period.Annual)]
304304
[InlineData("O", Period.Annual)]
305-
[InlineData("BRK.B", Period.Annual)]
305+
[InlineData("BRK-B", Period.Annual)]
306306
[InlineData("CX", Period.Annual)]
307307
public async Task GetCompanyKeyMetricsAsync(string symbol, Period period)
308308
{

0 commit comments

Comments
 (0)