From 8a4058866e96a390e4216771d7b5ec7307efc528 Mon Sep 17 00:00:00 2001 From: Makisuo Date: Thu, 22 Oct 2026 18:49:39 +0200 Subject: [PATCH] test(integrations): pass the initiator in the GitHub admin-role connect cases #1675 made completeConnect require the signed-in initiator; the admin-role cases from #1685 still called it with three arguments, so every case died on initiator.orgId before reaching the membership check. Backend test files are outside typecheck, so only the test run caught it. --- .../vcs/vendor/github/__tests__/GithubConnectService.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend/src/services/integrations/vcs/vendor/github/__tests__/GithubConnectService.test.ts b/packages/backend/src/services/integrations/vcs/vendor/github/__tests__/GithubConnectService.test.ts index 092be77215..4bff2afe0b 100644 --- a/packages/backend/src/services/integrations/vcs/vendor/github/__tests__/GithubConnectService.test.ts +++ b/packages/backend/src/services/integrations/vcs/vendor/github/__tests__/GithubConnectService.test.ts @@ -279,7 +279,7 @@ describe("GithubConnectService", () => { const { state } = yield* svc.startConnect(asOrgId("org_test"), asUserId("user_1"), { callbackUrl: "https://tunnel.example/cb", }) - const exit = yield* svc.completeConnect("42", state, TEST_CODE).pipe(Effect.exit) + const exit = yield* svc.completeConnect("42", state, TEST_CODE, INITIATOR).pipe(Effect.exit) assert.deepStrictEqual(roleUrls, [ c.account === "Organization" ? "/user/memberships/orgs/octo" : "/user", ])