Merge pull request #9543 from GilbertCherrie/remove_angular_grid_code

Remove angular grid code

Author: Fryguy

app/controllers/application_controller.rb

@@ -1171,20 +1171,9 @@ def get_view(db, options = {}, fetch_data = false)
     view.extras[:auth_count]  = attrs[:auth_count]   if attrs[:auth_count]
     @targets_hash             = attrs[:targets_hash] if attrs[:targets_hash]
 
-    # Set up the grid variables for list view, with exception models below
-    if grid_hash_conditions(view) && fetch_data
-      @grid_hash = view_to_hash(view, fetch_data)
-    end
-
     [view, get_view_pages(dbname, view)]
   end
 
-  def grid_hash_conditions(view)
-    !%w[Job MiqProvision MiqReportResult MiqTask].include?(view.db) &&
-      !(view.db.ends_with?("Build") && view.db != "ContainerBuild") &&
-      !@force_no_grid_xml
-  end
-
   def get_chart_where_clause(sb_controller = nil)
     # If doing charts, limit the records to ones showing in the chart
     sb_controller ||= params[:sb_controller]
@@ -1282,48 +1271,10 @@ def render_or_redirect_partial(pfx)
     end
   end
 
-  def replace_list_grid
-    view = @view
-    button_div = 'center_tb'
-    action_url = if @lastaction == "scan_history"
-                   "scan_history"
-                 elsif %w[all_jobs jobs ui_jobs all_ui_jobs].include?(@lastaction)
-                   "jobs"
-                 elsif @lastaction == "get_node_info"
-                   nil
-                 elsif !@lastaction.nil?
-                   @lastaction
-                 else
-                   "show_list"
-                 end
-
-    ajax_url = !%w[SecurityGroup CloudVolume].include?(view.db)
-    ajax_url = false if request.parameters[:controller] == "service" && view.db == "Vm"
-    ajax_url = false unless @explorer
-
-    url = @showlinks == false ? nil : view_to_url(view, @parent)
-    grid_options = {:grid_id    => "list_grid",
-                    :grid_name  => "gtl_list_grid",
-                    :grid_hash  => @grid_hash,
-                    :button_div => button_div,
-                    :action_url => action_url}
-    js_options = {:sortcol      => @sortcol || nil,
-                  :sortdir      => @sortdir ? @sortdir[0..2] : nil,
-                  :row_url      => url,
-                  :row_url_ajax => ajax_url}
-
-    [grid_options, js_options]
-  end
-
   # RJS code to show tag box effects and replace the main list view area
   def replace_gtl_main_div(_options = {})
     return if params[:action] == "button" && @lastaction == "show"
 
-    if @grid_hash
-      # need to call this outside render :update
-      grid_options, js_options = replace_list_grid
-    end
-
     render :update do |page|
       page << javascript_prologue
       page.replace(:flash_msg_div, :partial => "layouts/flash_msg") # Replace the flash message
@@ -1332,16 +1283,9 @@ def replace_gtl_main_div(_options = {})
       if layout_uses_listnav?
         page.replace(:listnav_div, :partial => "layouts/listnav") # Replace accordion, if list_nav_div is there
       end
-      if @grid_hash
-        page.replace_html("list_grid", :partial => "layouts/list_grid", :locals => {:options => grid_options, :js_options => js_options})
-        # Reset the center buttons
-        page << "miqGridOnCheck();"
-      else
-        # No grid, replace the gtl div
-        # Replace the main div area contents
-        page.replace_html("main_div", :partial => "layouts/gtl")
-        page << "$('#adv_div').slideUp(0.3);" if params[:entry]
-      end
+      # Replace the main div area contents
+      page.replace_html("main_div", :partial => "layouts/gtl")
+      page << "$('#adv_div').slideUp(0.3);" if params[:entry]
     end
   end
 

app/controllers/infra_networking_controller.rb

@@ -330,7 +330,6 @@ def replace_right_cell(options = {})
       partial_locals = {:controller =>'infra_networking'}
       if partial == 'layouts/x_gtl'
         partial_locals[:action_url] = @lastaction
-        presenter[:parent_id] = @record.id # Set parent rec id for JS function miqGridSort to build URL
         presenter[:parent_class] = params[:controller] # Set parent class for URL also
       end
       presenter.update(:main_div, r[:partial => partial, :locals => partial_locals])

app/controllers/vm_common.rb

@@ -1001,10 +1001,6 @@ def replace_right_cell(options = {})
       partial_locals = { :controller => 'vm' }
       if partial == 'layouts/x_gtl'
         partial_locals[:action_url] = @lastaction
-
-        # Set parent record id & class for JS function miqGridSort to build URL
-        presenter[:parent_id]    = @record.id
-        presenter[:parent_class] = params[:controller]
       end
       presenter.update(:main_div, r[:partial => partial, :locals => partial_locals])
 

app/javascript/.eslintrc.json

@@ -16,7 +16,6 @@
     "miqSparkleOn": true,
     "miqToggleUserOptions": true,
     "miqTreeActivateNode": true,
-    "miqOrderService": true,
     "miqQueueReport": true
   },
   "extends": ["airbnb", "plugin:jest/recommended"],

app/javascript/oldjs/application.js

@@ -25,8 +25,6 @@ require('./miq_c3_config.js');
 require('./miq_ujs_bindings.js');
 require('./miq_tree.js');
 require('./miq_formatters.js');
-require('./miq_grid.js');
-require('./miq_list_grid.js');
 require('./miq_toolbar.js');
 require('./miq_c3.js');
 require('./miq_explorer.js');

app/javascript/oldjs/miq_application.js

@@ -1,4 +1,4 @@
-/* global add_flash getChartColumnDataValues getChartFormatedValue miqBrowserDetect miqExpressionPrefill miqFlashLater miqFlashSaved miqGridCheckAll miqGridGetCheckedRows miqMenu miqTreeObject miqValueStylePrefill recalculateChartYAxisLabels */
+/* global add_flash getChartColumnDataValues getChartFormatedValue miqBrowserDetect miqExpressionPrefill miqFlashLater miqFlashSaved miqMenu miqTreeObject miqValueStylePrefill recalculateChartYAxisLabels */
 
 // MIQ specific JS functions
 
@@ -351,40 +351,6 @@ window.miqValidateButtons = function(h_or_s, prefix) {
   }
 };
 
-// update all checkboxes on a form when the masterToggle checkbox is changed
-// parms: button_div=<id of div with buttons to update>
-window.miqUpdateAllCheckboxes = function(button_div) {
-  if (!miqDomElementExists('masterToggle')) {
-    return;
-  }
-
-  const state = $('#masterToggle').prop('checked');
-
-  if (ManageIQ.grids.gtl_list_grid) {
-    miqGridCheckAll(state);
-    const crows = miqGridGetCheckedRows();
-
-    ManageIQ.gridChecks = crows;
-    miqSetButtons(crows.length, button_div);
-  } else if ($('input.listcheckbox').length) {
-    // No list_grid on the screen
-    const cbs = $('input.listcheckbox')
-      .prop('checked', state)
-      .trigger('change');
-
-    miqUpdateButtons(cbs[0], button_div);
-  } else if ($("input[id^='storage_cb']").length) {
-    // to handle check/uncheck all for C&U collection
-    $("input[id^='storage_cb']")
-      .prop('checked', state)
-      .trigger('change');
-    miqJqueryRequest(miqPassFields(
-      '/configuration/form_field_changed',
-      { storage_cb_all: state }
-    ));
-  }
-};
-
 // Update buttons based on number of checkboxes that are checked
 // parms: obj=<checkbox element>, button_div=<id of div with buttons to update>
 window.miqUpdateButtons = function(obj, button_div) {
@@ -419,7 +385,7 @@ window.miqSetToolbarCount = function(count) {
 window.miqSetButtons = function(count, button_div) {
   if (button_div.match('_tb$') && count === 0) {
     // FIXME: this should be happening regardless of `count === 0`
-    // ..but that needs more refactoring around miqUpdateAllCheckboxes, miqUpdateButtons, etc.
+    // ..but that needs more refactoring around miqUpdateButtons, etc.
     miqSetToolbarCount(count);
     return;
   }
@@ -438,24 +404,6 @@ window.DoNav = function(theUrl) {
   document.location.href = theUrl;
 };
 
-// Routines to get the size of the window
-window.miqResetSizeTimer = function() {
-  const height = window.innerHeight;
-  const offset = 427;
-  let h = height - offset;
-
-  if (h < 200) {
-    h = 200;
-  }
-
-  // Adjust certain elements, if present
-  if (miqDomElementExists('list_grid')) {
-    $('#list_grid').css({ height: `${h}px` });
-  } else if (miqDomElementExists('logview')) {
-    $('#logview').css({ height: `${h}px` });
-  }
-};
-
 // Pass fields to server given a URL and fields in name/value pairs
 window.miqPassFields = function(url, args) {
   return `${url}?${$.param(args)}`;
@@ -1460,7 +1408,6 @@ $(() => {
 
   $(window).on('resize', miqInitAccordions);
   $(window).on('resize', miqInitMainContent);
-  $(window).on('resize', _.debounce(miqResetSizeTimer, 1000));
 
   check_for_ellipsis();
 });
@@ -1493,3 +1440,16 @@ window.redirectLogin = function(msg) {
   add_flash(msg, 'warning');
   window.document.location.href = '/dashboard/login?timeout=true';
 };
+
+// Needed for optimization page queue report button
+window.miqQueueReport = function(id) {
+  const url = `/optimization/queue_report/${id}`;
+  window.miqSparkleOn();
+  http
+    .post(url, {})
+    .then((data) => {
+      window.add_flash(data.flash, 'success');
+      window.miqSparkleOff();
+    })
+    .catch(() => window.miqSparkleOff());
+};

app/javascript/oldjs/miq_global.js

@@ -1,20 +1,19 @@
 // global variables
 if (!window.ManageIQ) {
   window.ManageIQ = {
-    actionUrl: null, // action URL used in JS function miqGridSort
     afterOnload: null, // JS code to be evaluated after onload
     angular: {
       app: null, // angular application
       eventNotificationsData: null, // used by the notification drawer
-      rxSubject: null,  // an observable
-      scope: null,  // a scope which will have .angularForm after loading, for miqCheckForChanges
+      rxSubject: null, // an observable
+      scope: null, // a scope which will have .angularForm after loading, for miqCheckForChanges
     },
     asynchronous_notifications: false, // disabled by default, server overrides it in application.html.haml
     browser: null, // browser name
     calendar: { // TODO about to be removed
       calDateFrom: null, // to limit calendar starting
       calDateTo: null, // to limit calendar ending
-      calSkipDays: null,  // to disable specific days of week
+      calSkipDays: null, // to disable specific days of week
     },
     changes: null, // indicate if there are unsaved changes
     charts: {
@@ -49,13 +48,13 @@ if (!window.ManageIQ) {
     i18n: {
       mark_translated_strings: false,
     },
-    logoutInProgress: false,  // prevent redirectLogin *during* logout and group change
+    logoutInProgress: false, // prevent redirectLogin *during* logout and group change
     menu: [],
     mouse: {
       x: null, // mouse X coordinate for popup menu
       y: null, // mouse Y coordinate for popup menu
     },
-    move: { //methods to move elements between Arrays or in an Array
+    move: { // methods to move elements between Arrays or in an Array
     },
     noCollapseEvent: false, // enable/disable events fired after collapsing an accordion
     observe: { // keeping track of data-miq_observe requests
@@ -71,8 +70,6 @@ if (!window.ManageIQ) {
       debounced: {}, // running debounces
     },
     record: {
-      parentClass: null, // parent record ID for JS function miqGridSort to build URL
-      parentId: null, // parent record ID for JS function miqGridSort to build URL
       recordId: null, // record being displayed or edited
     },
     redux: { // Redux API - app/javascript/miq-redux