Merge pull request #9742 from asirvadAbrahamVarghese/upgrade-webpack-4-plugins

Upgrade webpack 4 plugins

Author: Fryguy

app/javascript/components/custom-url-tabs/index.jsx

@@ -25,7 +25,7 @@ const CustomURLTabs = ({
   };
 
   const fixTabStyling = () => {
-    document.getElementsByClassName(activeTabClassName).forEach((element) => {
+    [...document.getElementsByClassName(activeTabClassName)].forEach((element) => {
       element.classList.remove(activeTabClassName);
     });
     document.getElementsByClassName('selected')[0].classList.add(activeTabClassName);

config/webpack/development.js

@@ -1,6 +1,6 @@
 // Note: You must restart bin/webpack-dev-server for changes to take effect
 
-const merge = require('webpack-merge')
+const { merge } = require('webpack-merge')
 const sharedConfig = require('./shared.js')
 const { settings, output } = require('./configuration.js')
 const { env } = require('process')

config/webpack/loaders.js

@@ -1,4 +1,4 @@
-const merge = require('webpack-merge');
+const { merge } = require('webpack-merge');
 
 const { env, publicPath } = require('./configuration.js');
 const babelrc = require('../../.babelrc.js');

config/webpack/production.js

@@ -2,7 +2,7 @@
 
 /* eslint global-require: 0 */
 
-const merge = require('webpack-merge');
+const { merge } = require('webpack-merge');
 const CompressionPlugin = require('compression-webpack-plugin');
 const sharedConfig = require('./shared.js');
 

config/webpack/shared.js

@@ -6,7 +6,7 @@
 const webpack = require('webpack');
 const { basename, dirname, join, resolve } = require('path');
 const { sync } = require('glob');
-const ManifestPlugin = require('webpack-manifest-plugin');
+const { WebpackManifestPlugin } = require('webpack-manifest-plugin');
 const extname = require('path-complete-extname');
 const DuplicatePackageCheckerPlugin = require('duplicate-package-checker-webpack-plugin');
 const { SplitChunksPlugin } = require('webpack').optimize;
@@ -62,7 +62,7 @@ let plugins = [
     'process.env.CYPRESS': JSON.stringify(env.CYPRESS),
   }),
 
-  new ManifestPlugin({
+  new WebpackManifestPlugin({
     publicPath: output.publicPath,
     writeToFileEmit: true,
   }),

config/webpack/test.js

@@ -1,6 +1,6 @@
 // Note: You must restart bin/webpack-dev-server for changes to take effect
 
-const merge = require('webpack-merge')
+const { merge } = require('webpack-merge')
 const sharedConfig = require('./shared.js')
 
 module.exports = merge(sharedConfig, {

cypress/support/commands/menu.js

@@ -52,7 +52,7 @@ Cypress.Commands.add('menuItems', () => {
           if ($li[0].className === 'bx--side-nav__item') {
             const parent = $li.children().children()[0].innerText;
             cy.get($li).click().then(() => {
-              $li.children()[1].children.forEach((child) => {
+              [...$li.children()[1].children].forEach((child) => {
                 subChildren.push({ title: child.innerText, href: child.children[0].href });
               });
               children.push({title: parent, items: subChildren });

package.json

@@ -55,7 +55,7 @@
     "angular-ui-codemirror": "~0.3.0",
     "angular-ui-sortable": "~0.19.0",
     "angular.validators": "~4.4.3",
-    "array-includes": "^3.1.6",
+    "array-includes": "^3.1.9",
     "awesome-debounce-promise": "^2.1.0",
     "bootstrap-filestyle": "~1.2.1",
     "bootstrap-select": "^1.13.18",
@@ -70,7 +70,7 @@
     "d3": "^7.8.2",
     "dompurify": "^3.2.4",
     "eonasdan-bootstrap-datetimepicker": "~4.17.49",
-    "es6-shim": "~0.35.3",
+    "es6-shim": "~0.35.8",
     "history": "^4.7.2",
     "jquery": "~2.2.4",
     "jquery-ui": "~1.13.2",
@@ -107,7 +107,7 @@
     "sprintf-js": "~1.1.1",
     "table-resolver": "^4.1.1",
     "ui-select": "0.19.8",
-    "whatwg-fetch": "~2.0.4",
+    "whatwg-fetch": "~3.6.20",
     "xml_display": "~0.1.1"
   },
   "devDependencies": {
@@ -127,7 +127,7 @@
     "babel-jest": "~25.5.1",
     "babel-loader": "~8.4.0",
     "compression-webpack-plugin": "^6.1.1",
-    "core-js": "~3.6.4",
+    "core-js": "~3.47.0",
     "core-js-compat": "~3.2.1",
     "css-loader": "~3.4.2",
     "cypress": "~15.7.0",
@@ -160,20 +160,20 @@
     "postcss-loader": "~3.0.0",
     "precss": "~4.0.0",
     "react-test-renderer": "~16.8.0",
-    "regenerator-runtime": "~0.13.5",
+    "regenerator-runtime": "~0.14.1",
     "resolve-url-loader": "~3.1.5",
     "sass": "~1.58.0",
     "sass-loader": "~8.0.2",
     "style-loader": "~1.1.3",
     "stylelint": "~14.5.1",
     "stylelint-config-standard": "~20.0.0",
     "stylelint-scss": "^4.0.0",
-    "webpack": "~4.46.0",
-    "webpack-cli": "~3.3.12",
+    "webpack": "~4.47.0",
+    "webpack-cli": "~4.10.0",
     "webpack-dev-server": "~5.2.0",
-    "webpack-manifest-plugin": "~2.2.0",
-    "webpack-merge": "~4.2.2",
-    "webpack-stats-plugin": "^0.3.2"
+    "webpack-manifest-plugin": "~4.1.1",
+    "webpack-merge": "~6.0.1",
+    "webpack-stats-plugin": "^1.1.3"
   },
   "engines": {
     "node": "^20.19.5",