[Bug] update notification noderestart restarts wrong runtime

[sdetweil]

Environment

MagicMirror² version:
Node version:
npm version:
Platform:

Which start option are you using?

node --run start:x11

Are you using PM2?

No

Module

updatenotification

Have you tried disabling other modules?

• Yes
• No

Have you searched if someone else has already reported the issue on the forum or in the issues?

• Yes

What did you do?

Configuration

set updatenotification to restart mm

<!-- Paste relevant code here -->
updateAutorestart: true

Steps to reproduce the issue:

cause a change in some installed 3rd party module

What did you expect to happen?

MM would restart

What actually happened?

mm failed to start, unable to find WAYLAND_DISPLAY env variable.. as I am using x11

Additional comments

updatenotification uses

Spawn("node --run start"  <--- this uses wayland now

but this instance needs

Spawn("node --run start:x11"
or 
Spawn("node --run start:windows"

one could find the previous start command in process list

ps -ef | grep node | grep start
sam      4138959 2915099  0 16:37 pts/1    00:00:00 node --run start:x11

Participation

• I am willing to submit a pull request for this change.

[khassel]

you can get the start params from https://nodejs.org/docs/latest/api/process.html#processargv

[sdetweil]

put this in the node_helper.js (using npm run start:x11, or node --run start:x11)

const { argv } = require('node:process');

        start: ()=>{
                console.log("args=",argv);
        },

got this

 args= [
  '/home/sam/MagicMirror/node_modules/electron/dist/electron',
  'js/electron.js'
]

[khassel]

yes, this is exactly what is executed by node --run start:x11

[sdetweil]

yes, but I think that is not what we want to execute