From 92a93fc0eb9b511d79a7868d8c3429049af11887 Mon Sep 17 00:00:00 2001 From: aaron hu Date: Fri, 6 Feb 2026 17:35:08 +0800 Subject: [PATCH 1/2] refactor: rename ChucksHybridSearchRetriever to ChunksHybridSearchRetriever --- surfsense_backend/app/retriever/chunks_hybrid_search.py | 2 +- surfsense_backend/app/services/connector_service.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/surfsense_backend/app/retriever/chunks_hybrid_search.py b/surfsense_backend/app/retriever/chunks_hybrid_search.py index 9aa301386..968408d81 100644 --- a/surfsense_backend/app/retriever/chunks_hybrid_search.py +++ b/surfsense_backend/app/retriever/chunks_hybrid_search.py @@ -1,7 +1,7 @@ from datetime import datetime -class ChucksHybridSearchRetriever: +class ChunksHybridSearchRetriever: def __init__(self, db_session): """ Initialize the hybrid search retriever with a database session. diff --git a/surfsense_backend/app/services/connector_service.py b/surfsense_backend/app/services/connector_service.py index 251241e96..8466aaf1e 100644 --- a/surfsense_backend/app/services/connector_service.py +++ b/surfsense_backend/app/services/connector_service.py @@ -16,14 +16,14 @@ SearchSourceConnector, SearchSourceConnectorType, ) -from app.retriever.chunks_hybrid_search import ChucksHybridSearchRetriever +from app.retriever.chunks_hybrid_search import ChunksHybridSearchRetriever from app.retriever.documents_hybrid_search import DocumentHybridSearchRetriever class ConnectorService: def __init__(self, session: AsyncSession, search_space_id: int | None = None): self.session = session - self.chunk_retriever = ChucksHybridSearchRetriever(session) + self.chunk_retriever = ChunksHybridSearchRetriever(session) self.document_retriever = DocumentHybridSearchRetriever(session) self.search_space_id = search_space_id self.source_id_counter = ( From cd82e78ac71d083575c93e6aa2efc3c8c51e6c33 Mon Sep 17 00:00:00 2001 From: aaron hu Date: Sat, 7 Feb 2026 10:36:39 +0800 Subject: [PATCH 2/2] fix: add error handling for embedding generation --- .../app/retriever/chunks_hybrid_search.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/surfsense_backend/app/retriever/chunks_hybrid_search.py b/surfsense_backend/app/retriever/chunks_hybrid_search.py index 968408d81..f16225ab7 100644 --- a/surfsense_backend/app/retriever/chunks_hybrid_search.py +++ b/surfsense_backend/app/retriever/chunks_hybrid_search.py @@ -1,5 +1,8 @@ +import logging from datetime import datetime +logger = logging.getLogger(__name__) + class ChunksHybridSearchRetriever: def __init__(self, db_session): @@ -39,8 +42,12 @@ async def vector_search( from app.db import Chunk, Document # Get embedding for the query - embedding_model = config.embedding_model_instance - query_embedding = embedding_model.embed(query_text) + try: + embedding_model = config.embedding_model_instance + query_embedding = embedding_model.embed(query_text) + except Exception as e: + logger.error(f"fail to call embedding model: {e!s}") + return [] # Build the query filtered by search space query = (