SAM: normalize to 'MyFunction' and comment on HTTP invocation

Author: ghukill

Makefile

@@ -70,7 +70,7 @@ sam-http-run: # SAM: Run lambda locally as an HTTP server
 	sam local start-api --template tests/sam/template.yaml --env-vars tests/sam/env.json
 
 sam-http-ping: # SAM: Send curl command to SAM HTTP server
-	curl --location 'http://localhost:3000/myapp' \
+	curl --location 'http://localhost:3000/myfunction' \
 	--header 'Content-Type: application/json' \
 	--data '{"msg":"in a bottle"}'
 

README.md

@@ -63,7 +63,7 @@ Useful when the Lambda will sit behind an ALB, Function URL, or API Gateway.  Th
 make sam-http-run
 ```
 
-This starts a server at `http://localhost:3000`.  Requests must include a path, e.g. `/myapp`, but are arbitrary insofar as the lambda does not utilize them in the request payload. 
+This starts a server at `http://localhost:3000`.  Requests must include a path, e.g. `/myfunction`, but are arbitrary insofar as the lambda does not utilize them in the request payload. 
 
 3- In another terminal, perform an HTTP request via another `Makefile` command:
 ```shell

tests/sam/env.json.template

@@ -1,3 +1,3 @@
 {
-  "MyApp": {}
+  "MyFunction": {}
 }

tests/sam/template.yaml

@@ -1,19 +1,20 @@
 AWSTemplateFormatVersion: "2010-09-09"
 Transform: AWS::Serverless-2016-10-31
 Resources:
-  MyApp:
+  MyFunction:
     Type: AWS::Serverless::Function
     Properties:
       PackageType: Image
       Timeout: 900
       MemorySize: 1024
+      ImageUri: myfunction:latest
       Events:
-        BagitApi:
+        # NOTE: this Event handler is needed for HTTP invocations of the lambda, not direct invocations
+        HTTPRequest:
           Type: HttpApi
           Properties:
             Path: /{proxy+}
             Method: ANY
-      ImageUri: myapp:latest
       Environment:
         # While tests/sam/env.json is required for sensitive env vars, ALL env vars
         # used in the lambda must exist here as well, even just as "..." placeholders.
@@ -25,4 +26,4 @@ Resources:
       DockerContext: ../../. # Build Lambda Dockerfile
       DockerTag: latest
       Dockerfile: Dockerfile
-      SamResourceId: MyApp
+      SamResourceId: MyFunction