Commit e09512f
committed
Update Makefile, pre-commit, linting, and dependency conventions
Why these changes are being introduced:
These changes encapsulate some discussions to update some devops conventions
that operate at the intersection of the Makefile, pre-commit hooks, linting,
and dependency handling. These changes were prompted by a critical mass of
some structure creep over time, and some feedback of unhelpful friction
in some areas.
How this addresses that need:
* linting section reworked in Makefile
* pre-commit fires only on git push
* pre-commit no longer runs commands that modify code
* `ruff format` is used in place of `black`
* vulernability scanning moved to `make security`
* security scanning removed from linting and pre-commit hooks
Side effects of this change:
* Vulnerability scanning is an ad-hoc decision by developers in the short-term,
with notifications in Github via dependabot. Longer term, we will rely on
renovate for rolling dependency updates.
* Local commits are no longer constrained by pre-commit hooks, but hooks
are enforced when pushing to Github.
* We move further into the ecosystem of astral's ruff library, using the
built-in formatter instead of black.
Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-16761 parent 12415eb commit e09512f
4 files changed
+255
-272
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
6 | | - | |
7 | | - | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | | - | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
22 | 26 | | |
23 | 27 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 28 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 47 | + | |
| 48 | + | |
53 | 49 | | |
54 | | - | |
55 | | - | |
56 | 50 | | |
57 | 51 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 52 | + | |
| 53 | + | |
67 | 54 | | |
68 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
69 | 59 | | |
70 | 60 | | |
71 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
| |||
0 commit comments