Skip to content

Bug: periodic_bc is not communicated #1827

Description

@wilfonba

The logical storage array periodic_bc is not communicated after its elements are assigned by rank 0 in src/simulation/m_start_up.fpp. This breaks periodic Euler-Lagrange simulations on more than 1 MPI rank. This was likely introduced when the input parameter broadcasts were largely automated.

Diff to fix the problem when I (or someone else) get to it

diff --git a/src/simulation/m_mpi_proxy.fpp b/src/simulation/m_mpi_proxy.fpp
index f8fe85a9..3752d0f1 100644
--- a/src/simulation/m_mpi_proxy.fpp
+++ b/src/simulation/m_mpi_proxy.fpp
@@ -146,9 +146,11 @@ contains
             #:endfor
         end do
 
-        ! manual: cfl_dt (runtime-computed logical), bc_io (BC-file existence)
+        ! manual: cfl_dt (runtime-computed logical), bc_io (BC-file existence),
+        !         periodic_bc (global boundary periodicity flags)
         call MPI_BCAST(cfl_dt, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)
         call MPI_BCAST(bc_io, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)
+        call MPI_BCAST(periodic_bc, 3, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)
 
         ! manual: shear_stress, bulk_stress (derived from Re_size post-init on all ranks),
         !         bodyForces (derived from bf_x/y/z)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions