fix #1418

Author: sumneko

changelog.md

@@ -5,6 +5,7 @@
 * `FIX` [#1403](https://github.com/sumneko/lua-language-server/issues/1403)
 * `FIX` [#1405](https://github.com/sumneko/lua-language-server/issues/1405)
 * `FIX` [#1406](https://github.com/sumneko/lua-language-server/issues/1406)
+* `FIX` [#1418](https://github.com/sumneko/lua-language-server/issues/1418)
 
 ## 3.5.1
 `2022-7-26`

script/provider/diagnostic.lua

@@ -515,6 +515,7 @@ function m.diagnosticsScope(uri, force)
     local id = 'diagnosticsScope:' .. scp:getName()
     await.close(id)
     await.call(function () ---@async
+        await.sleep(0.0)
         m.awaitDiagnosticsScope(uri, function (fileUri)
             xpcall(m.doDiagnostic, log.error, fileUri, true)
         end)

script/vm/compiler.lua

@@ -6,6 +6,8 @@ local files      = require 'files'
 ---@class vm
 local vm         = require 'vm.vm'
 
+local LOCK = {}
+
 ---@class parser.object
 ---@field _compiledNodes  boolean
 ---@field _node           vm.node
@@ -1161,6 +1163,15 @@ local compilerSwitch = util.switch()
                         vm.setNode(src, vm.createNode(src.value))
                         vm.setNode(src, node:copy():asTable())
                     else
+                        guide.eachSource(src.value, function (child)
+                            if  child.type == 'getlocal'
+                            and child.node == source then
+                                return
+                            end
+                            if LOCK[child] then
+                                vm.removeNode(child)
+                            end
+                        end)
                         vm.setNode(src, vm.compileNode(src.value), true)
                     end
                 else
@@ -1811,9 +1822,11 @@ function vm.compileNode(source)
 
     ---@cast source parser.object
     vm.setNode(source, vm.createNode(), true)
+    LOCK[source] = true
     compileByGlobal(source)
     compileByNode(source)
     matchCall(source)
+    LOCK[source] = nil
 
     local node = vm.getNode(source)
     ---@cast node -?

script/vm/function.lua

@@ -201,7 +201,7 @@ end
 ---@return parser.object[]
 function vm.getMatchedFunctions(func, args, mark)
     local funcs = {}
-    local node = vm.compileNode(func)
+    local node = vm.getNode(func) or vm.compileNode(func)
     for n in node:eachObject() do
         if n.type == 'function'
         or n.type == 'doc.type.function' then

test/full/projects.lua

@@ -57,4 +57,4 @@ local function doProjects(pathname)
 end
 
 --doProjects [[C:\SSSEditor\client\Output\Lua]]
-doProjects [[C:\W3-Server\script]]
+--doProjects [[C:\W3-Server\script]]

test/tclient/init.lua

@@ -10,4 +10,5 @@ require 'tclient.tests.hover-pairs'
 require 'tclient.tests.change-workspace-folder'
 require 'tclient.tests.jump-source'
 require 'tclient.tests.load-relative-library'
+require 'tclient.tests.hover-set-local'
 require 'tclient.tests.build-meta'

test/tclient/tests/hover-set-local.lua

@@ -0,0 +1,45 @@
+local lclient   = require 'lclient'
+local ws        = require 'workspace'
+local await     = require 'await'
+
+---@async
+lclient():start(function (client)
+    client:registerFakers()
+    client:initialize()
+
+    client:notify('textDocument/didOpen', {
+        textDocument = {
+            uri = 'file://test.lua',
+            languageId = 'lua',
+            version = 0,
+            text = [[
+---@class Class
+local m
+
+---@return Class
+function m:f() end
+
+---@type Class
+local v
+v = v:f()
+]]
+        }
+    })
+
+    ws.awaitReady()
+
+    await.sleep(0.1)
+
+    local hover1 = client:awaitRequest('textDocument/hover', {
+        textDocument = { uri = 'file://test.lua' },
+        position = { line = 7, character = 6 },
+    })
+
+    local hover2 = client:awaitRequest('textDocument/hover', {
+        textDocument = { uri = 'file://test.lua' },
+        position = { line = 8, character = 0 },
+    })
+
+    assert(hover1.contents.value:find 'Class')
+    assert(hover2.contents.value:find 'Class')
+end)