From 0db56a159000d175c82e760b8be676b7f7549e28 Mon Sep 17 00:00:00 2001 From: Cristian Magherusan-Stanciu Date: Fri, 16 Oct 2026 16:08:37 +0200 Subject: [PATCH] test(cmd): restore toolCfg in validator tests so shuffle order is safe Validator tests assigned toolCfg = Config{} without restoring it, leaving a zeroed config (CoverageLookbackDays 0) that later tests relying on the flag defaults inherited under -shuffle=on. Restore via the existing saveGlobalVars helper in t.Cleanup. Closes #2208 Co-Authored-By: Claude Opus 5.5 --- cmd/validators_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmd/validators_test.go b/cmd/validators_test.go index 99ef4207c..cd548f16d 100644 --- a/cmd/validators_test.go +++ b/cmd/validators_test.go @@ -140,6 +140,7 @@ func TestValidateNumericRanges(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { // Setup + t.Cleanup(saveGlobalVars().restore) toolCfg = Config{} tt.setupFunc() @@ -237,6 +238,7 @@ func TestValidatePaymentAndTerm(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { // Setup + t.Cleanup(saveGlobalVars().restore) toolCfg = Config{} tt.setupFunc() @@ -428,6 +430,7 @@ func TestValidateFilePaths(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { // Setup + t.Cleanup(saveGlobalVars().restore) toolCfg = Config{} cleanup := tt.setupFunc() defer cleanup() @@ -562,6 +565,7 @@ func TestValidateTargetCoverage(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { + t.Cleanup(saveGlobalVars().restore) toolCfg = Config{Coverage: tt.coverage, TargetCoverage: tt.target, CoverageLookbackDays: 30} var cmd *cobra.Command if tt.useCobraCmd {