Updated tests for ArangoDB 3.8

Author: LaravelFreelancerNL

phpunit.xml

@@ -16,6 +16,6 @@
         </include>
     </coverage>
     <php>
-        <env name="ARANGODB_VERSION" value="3.7"/>
+        <env name="ARANGODB_VERSION" value="3.8"/>
     </php>
 </phpunit>

tests/ArangoClientTest.php

@@ -265,6 +265,6 @@ protected function checkHttp2Support()
             $this->markTestSkipped('The installed version of CURL does not support the HTTP2 protocol.');
         }
         // HTTP/2 is only supported by ArangoDB 3.7 and up.
-        $this->skipTestOnArangoVersionsBefore('3.7');
+        $this->skipTestOnArangoVersions('3.7');
     }
-}
+}

tests/SchemaManagerCollectionsTest.php

@@ -7,14 +7,24 @@
 class SchemaManagerCollectionsTest extends TestCase
 {
 
-    public function testGetCollections()
+    public function testGetCollectionsBeforeVersion38()
     {
+        $this->skipTestOnArangoVersions('3.8', '>=');
         $result = $this->schemaManager->getCollections();
 
         $this->assertLessThanOrEqual(count($result), 10);
         $this->assertIsObject($result[0]);
     }
 
+    public function testGetCollections()
+    {
+        $this->skipTestOnArangoVersions('3.8', '<');
+        $result = $this->schemaManager->getCollections();
+
+        $this->assertLessThanOrEqual(count($result), 8);
+        $this->assertIsObject($result[0]);
+    }
+
     public function testGetCollectionsWithoutSystem()
     {
         $result = $this->schemaManager->getCollections(true);
@@ -35,7 +45,7 @@ public function testGetCollection()
 
     public function testHasCollection()
     {
-        $result = $this->schemaManager->hasCollection('_fishbowl');
+        $result = $this->schemaManager->hasCollection('_graphs');
         $this->assertTrue($result);
 
         $result = $this->schemaManager->hasCollection('someNoneExistingCollection');
@@ -190,4 +200,4 @@ public function testCreateCollectionWithOptions()
         $this->assertTrue($result);
         $this->assertFalse($this->schemaManager->hasCollection($collection));
     }
-}
+}

tests/TestCase.php

@@ -41,9 +41,9 @@ protected function createTestDatabase()
         }
     }
 
-    protected function skipTestOnArangoVersionsBefore(string $version)
+    protected function skipTestOnArangoVersions(string $version, string $operator = '<')
     {
-        if (version_compare( getenv('ARANGODB_VERSION'), $version, '<' )) {
+        if (version_compare( getenv('ARANGODB_VERSION'), $version, $operator )) {
             $this->markTestSkipped('This test does not support ArangoDB versions before ' . $version);
         }
     }