updated based on review

Jolanrensen · Jolanrensen · commit 6e51b3406ec9 · 2023-04-08T15:44:33.000+02:00
diff --git a/core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt b/core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt
@@ -4213,7 +4213,7 @@ public interface ColumnsSelectionDsl<out T> : ColumnSelectionDsl<T>, SingleColum
      * ## ‎
      * Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.
      * This is useful when the type is not known at compile time or when the API function cannot be inlined.
-     * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))
+     *
      *
      * `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
      *
@@ -4252,7 +4252,7 @@ public interface ColumnsSelectionDsl<out T> : ColumnSelectionDsl<T>, SingleColum
      * ## ‎
      * Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.
      * This is useful when the type is not known at compile time or when the API function cannot be inlined.
-     * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))
+     *
      *
      * `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
      *
@@ -4330,7 +4330,7 @@ public inline fun <reified C> ColumnSet<*>.dfsOf(noinline filter: (ColumnWithPat
  * ## ‎
  * Finally, [colsOf] can also take a [KType] argument instead of a reified type.
  * This is useful when the type is not known at compile time or when the API function cannot be inlined.
- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))
+ *
  *
  * `df.`[select][DataFrame.select]` { `[colsOf][colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
  *
@@ -4358,7 +4358,7 @@ internal interface ColsOf
  * ## ‎
  * Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.
  * This is useful when the type is not known at compile time or when the API function cannot be inlined.
- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))
+ *
  *
  * `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
  *
@@ -4394,7 +4394,7 @@ private interface CommonColsOfDocs {
  * ## ‎
  * Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.
  * This is useful when the type is not known at compile time or when the API function cannot be inlined.
- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))
+ *
  *
  * `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
  *
@@ -4435,7 +4435,7 @@ public fun <C> ColumnSet<*>.colsOf(type: KType, filter: (DataColumn<C>) -> Boole
  * ## ‎
  * Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.
  * This is useful when the type is not known at compile time or when the API function cannot be inlined.
- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))
+ *
  *
  * `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
  *
diff --git a/core/generated-sources/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt b/core/generated-sources/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt
@@ -163,9 +163,9 @@ class ColumnsSelectionDslTests : TestBase() {
         }
 
         dfGroup.select { colGroup("name") } shouldBe dfGroup.select { name }
-        dfGroup.select { colGroup<String>("name") } shouldBe dfGroup.select { name }
+        dfGroup.select { colGroup<Name>("name") } shouldBe dfGroup.select { name }
         dfGroup.select { colGroup(pathOf("name")) } shouldBe dfGroup.select { name }
-        dfGroup.select { colGroup<String>(pathOf("name")) } shouldBe dfGroup.select { name }
+        dfGroup.select { colGroup<Name>(pathOf("name")) } shouldBe dfGroup.select { name }
         dfGroup.select { colGroup(Person::name) } shouldBe dfGroup.select { name }
 
         dfGroup.select { colGroup("name").colGroup("firstNames") } shouldBe dfGroup.select { name[firstNames] }
diff --git a/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt b/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt
@@ -1976,7 +1976,7 @@ public inline fun <reified C> ColumnSet<*>.dfsOf(noinline filter: (ColumnWithPat
  * {@include [LineBreak]}
  * Finally, [colsOf] can also take a [KType] argument instead of a reified type.
  * This is useful when the type is not known at compile time or when the API function cannot be inlined.
- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))
+ * {@comment TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325) }
  *
  * `df.`[select][DataFrame.select]` { `[colsOf][colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
  *
diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt
@@ -163,9 +163,9 @@ class ColumnsSelectionDslTests : TestBase() {
         }
 
         dfGroup.select { colGroup("name") } shouldBe dfGroup.select { name }
-        dfGroup.select { colGroup<String>("name") } shouldBe dfGroup.select { name }
+        dfGroup.select { colGroup<Name>("name") } shouldBe dfGroup.select { name }
         dfGroup.select { colGroup(pathOf("name")) } shouldBe dfGroup.select { name }
-        dfGroup.select { colGroup<String>(pathOf("name")) } shouldBe dfGroup.select { name }
+        dfGroup.select { colGroup<Name>(pathOf("name")) } shouldBe dfGroup.select { name }
         dfGroup.select { colGroup(Person::name) } shouldBe dfGroup.select { name }
 
         dfGroup.select { colGroup("name").colGroup("firstNames") } shouldBe dfGroup.select { name[firstNames] }

Original file line number	Diff line number	Diff line change
`@@ -4213,7 +4213,7 @@ public interface ColumnsSelectionDsl<out T> : ColumnSelectionDsl<T>, SingleColum`
`4213`	`4213`	`* ## ‎`
`4214`	`4214`	`* Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.`
`4215`	`4215`	`* This is useful when the type is not known at compile time or when the API function cannot be inlined.`
`4216`		`- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))`
	`4216`	`+ *`
`4217`	`4217`	`*`
`4218`	`4218`	* `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
`4219`	`4219`	`*`
`@@ -4252,7 +4252,7 @@ public interface ColumnsSelectionDsl<out T> : ColumnSelectionDsl<T>, SingleColum`
`4252`	`4252`	`* ## ‎`
`4253`	`4253`	`* Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.`
`4254`	`4254`	`* This is useful when the type is not known at compile time or when the API function cannot be inlined.`
`4255`		`- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))`
	`4255`	`+ *`
`4256`	`4256`	`*`
`4257`	`4257`	* `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
`4258`	`4258`	`*`
`@@ -4330,7 +4330,7 @@ public inline fun <reified C> ColumnSet<*>.dfsOf(noinline filter: (ColumnWithPat`
`4330`	`4330`	`* ## ‎`
`4331`	`4331`	`* Finally, [colsOf] can also take a [KType] argument instead of a reified type.`
`4332`	`4332`	`* This is useful when the type is not known at compile time or when the API function cannot be inlined.`
`4333`		`- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))`
	`4333`	`+ *`
`4334`	`4334`	`*`
`4335`	`4335`	* `df.`[select][DataFrame.select]` { `[colsOf][colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
`4336`	`4336`	`*`
`@@ -4358,7 +4358,7 @@ internal interface ColsOf`
`4358`	`4358`	`* ## ‎`
`4359`	`4359`	`* Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.`
`4360`	`4360`	`* This is useful when the type is not known at compile time or when the API function cannot be inlined.`
`4361`		`- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))`
	`4361`	`+ *`
`4362`	`4362`	`*`
`4363`	`4363`	* `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
`4364`	`4364`	`*`
`@@ -4394,7 +4394,7 @@ private interface CommonColsOfDocs {`
`4394`	`4394`	`* ## ‎`
`4395`	`4395`	`* Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.`
`4396`	`4396`	`* This is useful when the type is not known at compile time or when the API function cannot be inlined.`
`4397`		`- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))`
	`4397`	`+ *`
`4398`	`4398`	`*`
`4399`	`4399`	* `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
`4400`	`4400`	`*`
`@@ -4435,7 +4435,7 @@ public fun <C> ColumnSet<*>.colsOf(type: KType, filter: (DataColumn<C>) -> Boole`
`4435`	`4435`	`* ## ‎`
`4436`	`4436`	`* Finally, [colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf] can also take a [KType] argument instead of a reified type.`
`4437`	`4437`	`* This is useful when the type is not known at compile time or when the API function cannot be inlined.`
`4438`		`- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))`
	`4438`	`+ *`
`4439`	`4439`	`*`
`4440`	`4440`	* `df.`[select][org.jetbrains.kotlinx.dataframe.DataFrame.select]` { `[colsOf][org.jetbrains.kotlinx.dataframe.api.colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
`4441`	`4441`	`*`
Original file line number	Diff line number	Diff line change
`@@ -1976,7 +1976,7 @@ public inline fun <reified C> ColumnSet<*>.dfsOf(noinline filter: (ColumnWithPat`
`1976`	`1976`	`* {@include [LineBreak]}`
`1977`	`1977`	`* Finally, [colsOf] can also take a [KType] argument instead of a reified type.`
`1978`	`1978`	`* This is useful when the type is not known at compile time or when the API function cannot be inlined.`
`1979`		`- * (TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325))`
	`1979`	`+ * {@comment TODO: [Issue: #325, context receiver support](https://github.com/Kotlin/dataframe/issues/325) }`
`1980`	`1980`	`*`
`1981`	`1981`	* `df.`[select][DataFrame.select]` { `[colsOf][colsOf]`(`[typeOf][typeOf]`<`[Int][Int]`>()) }`
`1982`	`1982`	`*`