Skip to content

Conversation

@arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Nov 17, 2025

Screenshot from 2025-11-03 17-50-43 Screenshot from 2025-11-03 17-50-55 Screenshot from 2025-11-18 01-07-35

@arnavk23
Copy link
Contributor Author

@tmigot please review. On my system they are passing when I use one(T), T(i) and T(mod(i,5)).

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first batch of comments

@arnavk23
Copy link
Contributor Author

@tmigot Worked on your review comments but now seeing

  Expression: typeof(obj(nlp, x0)) == T
   Evaluated: Float64 == Float32

@arnavk23 arnavk23 requested a review from tmigot November 18, 2025 22:38
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnavk23 I stopped after the first file

@arnavk23 arnavk23 requested a review from tmigot November 24, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants