Make a lot of imports explicit

Author: Frankie Robertson

src/CatConfig.jl

@@ -2,8 +2,7 @@ module CatConfig
 
 export CatRules, CatLoopConfig
 
-using DocStringExtensions
-
+using DocStringExtensions: FUNCTIONNAME, TYPEDEF, TYPEDFIELDS
 using PsychometricsBazaarBase.Parameters
 
 using ..Aggregators: AbilityEstimator, AbilityTracker, ConsAbilityTracker,

src/Comparison.jl

@@ -3,17 +3,16 @@ module Comparison
 # TODO: We are overlapping a bit with CatRecorder here
 # Should be kept in mind and kept distinct or code reuse
 
-using StatsBase
 using FittedItemBanks: AbstractItemBank, ResponseType, subset
 using ..Responses
-using ..CatConfig: CatLoopConfig, CatRules
-using ..Aggregators: TrackedResponses, add_response!, Speculator, Aggregators, track!,
-                     pop_response!
-using ..DecisionTree: TreePosition, next!
+using ..Aggregators: TrackedResponses, Aggregators
 using Base: Iterators
 
-using HypothesisTests
-using EffectSizes
+using EffectSizes: CohenD, effectsize
+using HypothesisTests: ExactSignedRankTest, SignTest, UnequalVarianceTTest,
+                       pvalue
+using StatsBase: median, sample!
+
 using DataFrames: DataFrame
 using ComputerAdaptiveTesting: Stateful
 

src/ComputerAdaptiveTesting.jl

@@ -2,7 +2,7 @@ module ComputerAdaptiveTesting
 
 include("./hacks.jl")
 
-using Reexport
+using Reexport: Reexport, @reexport
 
 # Modules
 export ConfigBase, Responses, Aggregators

src/ConfigBase.jl

@@ -1,7 +1,7 @@
 module ConfigBase
 
-using Accessors
-using DocStringExtensions
+using Accessors: PropertyLens, opcompose
+using DocStringExtensions: TYPEDEF
 
 export CatConfigBase, walk
 

src/Responses.jl

@@ -3,8 +3,8 @@ module Responses
 using FittedItemBanks: AbstractItemBank,
                        BooleanResponse, MultinomialResponse, ResponseType, ItemResponse,
                        resp,
-                       DichotomousPointsItemBank, item_xs, item_ys
-using AutoHashEquals
+                       DichotomousPointsItemBank, item_ys
+using AutoHashEquals: @auto_hash_equals
 
 export Response, BareResponses, AbilityLikelihood, function_xs, function_ys
 

src/Sim.jl

@@ -4,7 +4,7 @@ using StatsBase
 using FittedItemBanks: AbstractItemBank, ResponseType
 using ..Responses
 using ..CatConfig: CatLoopConfig, CatRules
-using ..Aggregators: TrackedResponses, add_response!, Speculator, Aggregators
+using ..Aggregators: TrackedResponses, add_response!, Aggregators
 using ..NextItemRules: compute_criteria, best_item
 
 export run_cat, prompt_response, auto_responder

src/TerminationConditions.jl

@@ -1,10 +1,10 @@
 module TerminationConditions
 
-using DocStringExtensions
+using DocStringExtensions: TYPEDEF, TYPEDFIELDS
 using FittedItemBanks: AbstractItemBank
 using ..Aggregators: TrackedResponses
 using ..ConfigBase
-using PsychometricsBazaarBase.ConfigTools
+using PsychometricsBazaarBase.ConfigTools: @returnsome, find1_instance
 using FittedItemBanks
 
 export TerminationCondition,

src/aggregators/Aggregators.jl

@@ -11,14 +11,24 @@ using Distributions: Distribution, Normal, Distributions
 using Base.Threads
 using ForwardDiff: ForwardDiff
 
-using FittedItemBanks
+using FittedItemBanks: AbstractItemBank, ContinuousDomain,
+                       DichotomousSmoothedItemBank, DiscreteIndexableDomain,
+                       DomainType, ItemResponse, OneDimContinuousDomain,
+                       PointsItemBank, ResponseType, VectorContinuousDomain,
+                       domdims, item_params, resp, resp_vec, responses
 using ..Responses
 using ..Responses: concrete_response_type, function_xs, function_ys
 using ..ConfigBase
-using PsychometricsBazaarBase.ConfigTools
-using PsychometricsBazaarBase.Integrators
-using PsychometricsBazaarBase: Integrators
-using PsychometricsBazaarBase.Optimizers
+using PsychometricsBazaarBase.ConfigTools: @requiresome, @returnsome,
+                                           find1_instance, find1_type,
+                                           find1_type_sloppy
+using PsychometricsBazaarBase.Integrators: Integrators,
+                                           BareIntegrationResult,
+                                           FixedGridIntegrator, IntReturnType,
+                                           IntValue, Integrator,
+                                           PreallocatedFixedGridIntegrator,
+                                           normdenom
+using PsychometricsBazaarBase.Optimizers: OneDimOptimOptimizer, Optimizer
 using PsychometricsBazaarBase.ConstDistributions: std_normal, std_mv_normal
 
 import FittedItemBanks

src/decision_tree/DecisionTree.jl

@@ -1,14 +1,13 @@
 module DecisionTree
 
-using Mmap
+using Mmap: mmap
 
 using ComputerAdaptiveTesting.ConfigBase: CatConfigBase
 using ComputerAdaptiveTesting.PushVectors
 using ComputerAdaptiveTesting.NextItemRules
 using ComputerAdaptiveTesting.Aggregators
 using ComputerAdaptiveTesting.Responses: BareResponses, Response
-using FittedItemBanks
-using FittedItemBanks.DummyData: std_mv_normal
+using FittedItemBanks: AbstractItemBank, BooleanResponse, ResponseType
 
 # TODO: Remove ability tracking from here?
 Base.@kwdef struct AgendaItem

src/next_item_rules/NextItemRules.jl

@@ -10,25 +10,28 @@ Springer, New York, NY.
 """
 module NextItemRules
 
-using Accessors
-using DocStringExtensions
-using Reexport
-using PsychometricsBazaarBase.Parameters
-using LinearAlgebra
-using Random
+using DocStringExtensions: FUNCTIONNAME, TYPEDEF, TYPEDFIELDS
+using PsychometricsBazaarBase.Parameters: @with_kw
+using LinearAlgebra: det, tr
+using Random: AbstractRNG, Xoshiro
 
-using ..Responses: Response, BareResponses
+using ..Responses: BareResponses
 using ..ConfigBase
-using PsychometricsBazaarBase.ConfigTools
+using PsychometricsBazaarBase.ConfigTools: @requiresome, @returnsome,
+                                           find1_instance, find1_type
 using PsychometricsBazaarBase.Integrators: Integrator
 using PsychometricsBazaarBase: Integrators
 import PsychometricsBazaarBase.IntegralCoeffs
-using FittedItemBanks
-using FittedItemBanks: item_params
+using FittedItemBanks: AbstractItemBank, DiscreteDomain, DomainType,
+                       ItemResponse, OneDimContinuousDomain, domdims, item_params,
+                       resp, resp_vec, responses
 using ..Aggregators
 using ..Aggregators: covariance_matrix
 
-using Distributions, Base.Threads, Base.Order, StaticArrays
+using Distributions: logccdf, logcdf, pdf
+using Base.Threads
+using Base.Order
+using StaticArrays: SVector
 using ConstructionBase: constructorof
 import ForwardDiff