Merge pull request #220 from jverzani/issue_219

close issue #219

Author: jverzani

src/common.jl

@@ -545,7 +545,7 @@ Base.rem(n::AbstractPolynomial, d::AbstractPolynomial) = divrem(n, d)[2]
 Comparisons =#
 Base.isequal(p1::P, p2::P) where {P <: AbstractPolynomial} = hash(p1) == hash(p2)
 Base.:(==)(p1::AbstractPolynomial, p2::AbstractPolynomial) =
-    (p1.var == p2.var) && (coeffs(p1) == coeffs(p2))
+    check_same_variable(p1,p2) && (coeffs(p1) == coeffs(p2))
 Base.:(==)(p::AbstractPolynomial, n::Number) = degree(p) <= 0 && p[0] == n
 Base.:(==)(n::Number, p::AbstractPolynomial) = p == n
 

src/polynomials/ImmutablePolynomial.jl

@@ -138,7 +138,7 @@ function  isconstant(p::ImmutablePolynomial{N})  where {N}
 end
 for op in [:isequal, :(==)]
     @eval function Base.$op(p1::ImmutablePolynomial{N,T}, p2::ImmutablePolynomial{M,S}) where {N,T,M,S}
-        (p1.var == p2.var) || return false
+        check_same_variable(p1,p2) || return false
         p1s, p2s = coeffs(p1), coeffs(p2)
         (N == M  && $op(p1s,p2s)) &&  return  true
         n1 = findlast(!iszero, p1s) # now trim out zeros

src/polynomials/LaurentPolynomial.jl

@@ -153,7 +153,7 @@ end
 ##
 Base.copy(p::P) where {P <: LaurentPolynomial} = P(copy(coeffs(p)), range(p), p.var)
 Base.:(==)(p1::LaurentPolynomial, p2::LaurentPolynomial) =
-    (p1.var == p2.var) && (range(p1) == range(p2)) && (coeffs(p1) == coeffs(p2))
+    check_same_variable(p1, p2) && (range(p1) == range(p2)) && (coeffs(p1) == coeffs(p2))
 Base.hash(p::LaurentPolynomial, h::UInt) = hash(p.var, hash(range(p), hash(coeffs(p), h)))
 
 degree(p::LaurentPolynomial) = p.n[]

test/StandardBasis.jl

@@ -230,10 +230,19 @@ end
         @test P([0.5]) + 2 == P([2.5])
         @test 2 - P([0.5]) == P([1.5])
 
-        # check isapprox ignores variable mismatch when constants are involved, issue #217
-        @test Polynomial(1, :x) ≈ Polynomial(1, :y)
-        @test (variable(Polynomial, :x) ≈ variable(Polynomial, :x))
-        @test_throws ErrorException variable(Polynomial, :x) ≈ variable(Polynomial, :y)
+        # check how ==, ===, isapprox ignore variable mismatch when constants are involved, issue #217, issue #219
+        @test zero(P, :x) == zero(P, :y)
+        @test one(P, :x) == one(P, :y)
+        @test !(variable(P, :x) == variable(P,:y))
+
+        @test !(zero(P, :x) === zero(P, :y))
+        @test !(one(P, :x) === one(P, :y))
+        @test !(variable(P, :x) === variable(P,:y))
+
+        @test zero(P, :x) ≈ zero(P, :y)
+        @test one(P, :x) ≈ one(P, :y)
+        @test (variable(P, :x) ≈ variable(P, :x))
+        @test_throws ErrorException variable(P, :x) ≈ variable(P, :y)
 
     end
 end