Updated tests and correction constructor

Author: theogf

Project.toml

@@ -1,6 +1,6 @@
 name = "KernelFunctions"
 uuid = "ec8451be-7e33-11e9-00cf-bbf324bd1392"
-version = "0.2.1"
+version = "0.2.2"
 
 [deps]
 Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"

src/KernelFunctions.jl

@@ -15,7 +15,7 @@ export KernelSum, KernelProduct
 export SelectTransform, ChainTransform, ScaleTransform, LowRankTransform, IdentityTransform, FunctionTransform
 
 
-using Distances, LinearAlgebra, StaticArrays
+using Distances, LinearAlgebra
 using SpecialFunctions: lgamma, besselk
 using StatsFuns: logtwo
 using PDMats: PDMat

src/kernels/exponential.jl

@@ -70,7 +70,7 @@ end
 
 function GammaExponentialKernel(ρ::AbstractVector{T₁},gamma::T₂=2.0) where {T₁<:Real,T₂<:Real}
     @check_args(GammaExponentialKernel, gamma, gamma >= zero(T₂), "gamma > 0")
-    GammaExponentialKernel{T₁,ARDTransform{T₁,length(ρ)},T₂}(ScaleTransform(ρ),gamma)
+    GammaExponentialKernel{T₁,ARDTransform{T₁,length(ρ)},T₂}(ARDTransform(ρ),gamma)
 end
 
 function GammaExponentialKernel(t::Tr,gamma::T₁=2.0) where {Tr<:Transform,T₁<:Real}

test/test_constructors.jl

@@ -9,23 +9,21 @@ s = ScaleTransform(l)
 @testset "SqExponentialKernel" begin
     @test KernelFunctions.metric(SqExponentialKernel(l)) == SqEuclidean()
     @test isequal(transform(SqExponentialKernel(l)),s)
-    @test KernelFunctions.transform(SqExponentialKernel(vl)) == ScaleTransform(vl)
+    @test KernelFunctions.transform(SqExponentialKernel(vl)) == ARDTransform(vl)
     @test isequal(KernelFunctions.transform(SqExponentialKernel(s)),s)
 end
 
 ## MaternKernel
-ScaleTransform{Base.RefValue{Float64}}(Base.RefValue{Float64}(2.0))
-ScaleTransform{Base.RefValue{Float64}}(Base.RefValue{Float64}(2.0))
 @testset "MaternKernel" begin
     @test KernelFunctions.metric(MaternKernel(l)) == Euclidean()
     @test KernelFunctions.metric(Matern32Kernel(l)) == Euclidean()
     @test KernelFunctions.metric(Matern52Kernel(l)) == Euclidean()
     @test isequal(KernelFunctions.transform(MaternKernel(l)),s)
     @test isequal(KernelFunctions.transform(Matern32Kernel(l)),s)
     @test isequal(KernelFunctions.transform(Matern52Kernel(l)),s)
-    @test KernelFunctions.transform(MaternKernel(vl)) == ScaleTransform(vl)
-    @test KernelFunctions.transform(Matern32Kernel(vl)) == ScaleTransform(vl)
-    @test KernelFunctions.transform(Matern52Kernel(vl)) == ScaleTransform(vl)
+    @test KernelFunctions.transform(MaternKernel(vl)) == ARDTransform(vl)
+    @test KernelFunctions.transform(Matern32Kernel(vl)) == ARDTransform(vl)
+    @test KernelFunctions.transform(Matern52Kernel(vl)) == ARDTransform(vl)
     @test KernelFunctions.transform(MaternKernel(s)) == s
     @test KernelFunctions.transform(Matern32Kernel(s)) == s
     @test KernelFunctions.transform(Matern52Kernel(s)) == s

test/test_transform.jl

@@ -18,9 +18,15 @@ f(x) = sin.(x)
     ## Test Scale Transform
     @testset "ScaleTransform" begin
         t = ScaleTransform(s)
-        vt1 = ScaleTransform(v1)
-        vt2 = ScaleTransform(v2)
         @test all(KernelFunctions.transform(t,X).==s*X)
+        s2 = 2.0
+        KernelFunctions.set!(t,s2)
+        @test all(t.s.==[s2])
+    end
+    ## Test ARD Transform
+    @testset "ARDTransform" begin
+        vt1 = ARDTransform(v1)
+        vt2 = ARDTransform(v2)
         @test all(KernelFunctions.transform(vt1,X,1).==v1'.*X)
         @test all(KernelFunctions.transform(vt2,X,2).==v2.*X)
     end