Fix 346 (#347)

* Add methods for pairwise

* Bump patch

* Bump patch

Author: willtebbutt

Project.toml

@@ -1,6 +1,6 @@
 name = "KernelFunctions"
 uuid = "ec8451be-7e33-11e9-00cf-bbf324bd1392"
-version = "0.10.10"
+version = "0.10.11"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

src/utils.jl

@@ -165,6 +165,10 @@ function pairwise!(out::AbstractMatrix, d::PreMetric, x::RowVecs, y::RowVecs)
     return Distances.pairwise!(out, d, x.X, y.X; dims=1)
 end
 
+# Resolve ambiguity error for ColVecs vs RowVecs. #346
+pairwise(d::PreMetric, x::ColVecs, y::RowVecs) = pairwise(d, x, ColVecs(permutedims(y.X)))
+pairwise(d::PreMetric, x::RowVecs, y::ColVecs) = pairwise(d, ColVecs(permutedims(x.X)), y)
+
 dim(x) = 0 # This is the passes-by-default choice. For a proper check, implement `KernelFunctions.dim` for your datatype.
 dim(x::AbstractVector) = dim(first(x))
 dim(x::AbstractVector{<:AbstractVector{<:Real}}) = length(first(x))

test/utils.jl

@@ -93,6 +93,19 @@
             @test back(ones(size(X)))[1].X == ones(size(X))
         end
     end
+    @testset "ColVecs + RowVecs" begin
+        x_colvecs = ColVecs(randn(3, 5))
+        x_rowvecs = RowVecs(randn(7, 3))
+
+        @test isapprox(
+            pairwise(SqEuclidean(), x_colvecs, x_rowvecs),
+            pairwise(SqEuclidean(), collect(x_colvecs), collect(x_rowvecs)),
+        )
+        @test isapprox(
+            pairwise(SqEuclidean(), x_rowvecs, x_colvecs),
+            pairwise(SqEuclidean(), collect(x_rowvecs), collect(x_colvecs)),
+        )
+    end
     @testset "input checks" begin
         D = 3
         D⁻ = 2