Adding support for in place QR of views

Author: evelyne-ringoot

lib/cusolver/dense.jl

@@ -245,9 +245,9 @@ for (bname, fname, elty) in ((:cusolverDnSormqr_bufferSize, :cusolverDnSormqr, :
     @eval begin
         function ormqr!(side::Char,
                         trans::Char,
-                        A::CuMatrix{$elty},
-                        tau::CuVector{$elty},
-                        C::CuVecOrMat{$elty})
+                        A::StridedCuMatrix{$elty},
+                        tau::StridedCuVector{$elty},
+                        C::StridedCuVecOrMat{$elty})
             m,n = ndims(C) == 2 ? size(C) : (size(C, 1), 1)
             mA  = size(A, 1)
             k   = length(tau)

test/cusolver/dense.jl

@@ -490,12 +490,14 @@ l_range = (1:l) .+ (l_sub_start -1)
         q, r           = qr!(A)
         @test collect(d_q) ≈ Array(q)
         @test collect(d_r) ≈ Array(r)
+        A              = rand(elty, n, m)
+        d_A            = CuArray(A)
         A_view         = view(A, m_subrange, n_subrange)
         d_A_view       = view(d_A, m_subrange, n_subrange)
         d_q, d_r       = qr!(d_A_view)
         q, r           = qr!(A_view)
-        @test collect(d_q) ≈ Array(q)
-        @test collect(d_r) ≈ Array(r)
+        @test collect(d_q) ≈ collect(q)
+        @test collect(d_r) ≈ collect(r)
 
         A              = rand(elty, n)  # A and B are vectors
         d_A            = CuArray(A)
@@ -517,26 +519,6 @@ l_range = (1:l) .+ (l_sub_start -1)
         d_B            = view(d_B_large, n_range)
         @test collect(d_M \ d_B) ≈ M \ B
 
-        A              = rand(elty, n)  # A and B are vectors
-        d_A            = CuArray(A)
-        M              = qr!(A)
-        d_M            = qr!(d_A)
-        B              = rand(elty, n)
-        d_B            = CuArray(B)
-        @test collect(d_M \ d_B) ≈ M \ B
-        A_view         = view(A, n_subrange) 
-        d_A_view       = view(d_A, n_subrange)
-        M_view         = qr!(A_view)
-        d_M_view       = qr!(d_A_view)
-        B_view         = view(B, n_subrange)
-        d_B_view       = view(d_B, n_subrange)
-        @test collect(d_M_view \ d_B_view) ≈ M_view \ B_view
-        B_large        = rand(elty, n_large) 
-        B              = view(B_large, n_range)
-        d_B_large      = CuArray(B_large)
-        d_B            = view(d_B_large, n_range)
-        @test collect(d_M \ d_B) ≈ M \ B
-
         A              = rand(elty, m, n)  # A is a matrix and B,C is a vector
         d_A            = CuArray(A)
         M              = qr(A)
@@ -606,6 +588,8 @@ l_range = (1:l) .+ (l_sub_start -1)
         @test collect(d_M.R' * d_C) ≈ (M.R' * C)
         @test collect(d_C' * d_M.R) ≈ (C' * M.R)
         @test collect(d_C' * d_M.R') ≈ (C' * M.R')
+        A              = rand(elty, m, n) 
+        d_A            = CuArray(A)
         A_view         = view(A, m_subrange, n_subrange)
         d_A_view       = view(d_A, m_subrange, n_subrange)
         M_view         = qr!(A_view)
@@ -710,6 +694,8 @@ l_range = (1:l) .+ (l_sub_start -1)
         @test collect(d_M.R' * d_C) ≈ (M.R' * C)
         @test collect(d_C' * d_M.R) ≈ (C' * M.R)
         @test collect(d_C' * d_M.R') ≈ (C' * M.R')
+        A              = rand(elty, m, n)  
+        d_A            = CuArray(A)
         A_view         = view(A, m_subrange, n_subrange)
         d_A_view       = view(d_A, m_subrange, n_subrange)
         M_view         = qr!(A_view)