Merge pull request #23 from JuliaComputing/sp/naninf

fix serializing for nan/inf

Author: pfitzseb

src/TableView.jl

@@ -175,7 +175,7 @@ function table2json(rows, names, types; requested = nothing)
                 JSON.print(io, names[i])
                 i += 1
                 print(io, ':')
-                if col isa Number
+                if col isa Number && isfinite(col)
                     JSON.print(io, col)
                 elseif col === nothing
                     JSON.print(io, "nothing")

test/runtests.jl

@@ -1,5 +1,5 @@
 using TableView
-using Test, WebIO
+using Test, WebIO, Tables, JSON
 
 @testset "installation" begin
     version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))
@@ -19,6 +19,17 @@ end
     ]
     @test showtable(nttable) isa WebIO.Scope
 end
+@testset "inf and nan serializing" begin
+    rows = Tables.table([NaN Inf -Inf 0])
+    names = [:a, :b, :c, :d, :e, :f]
+    types = [Float64 for _ in 1:6]
+    json = TableView.table2json(rows, names, types)
+    firstrow = JSON.parse(json)[1]
+    @test firstrow["a"] == "NaN"
+    @test firstrow["b"] == "Inf"
+    @test firstrow["c"] == "-Inf"
+    @test firstrow["d"] == 0
+end
 @testset "normal array" begin
     array = rand(10, 10)
     @test showtable(array) isa WebIO.Scope