Merge pull request #43 from JuliaDiffEq/issingular

Specialize issingular on adj/tra

Author: ChrisRackauckas

Project.toml

@@ -1,6 +1,6 @@
 name = "ArrayInterface"
 uuid = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
-version = "2.6.0"
+version = "2.6.1"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/ArrayInterface.jl

@@ -122,6 +122,7 @@ issingular(T::Tridiagonal) = !issuccess(lu(A, check=false))
 issingular(A::Union{Hermitian,Symmetric}) = diaganyzero(bunchkaufman(A, check=false).LD)
 issingular(A::Union{LowerTriangular,UpperTriangular}) = diaganyzero(A.data)
 issingular(A::Union{UnitLowerTriangular,UnitUpperTriangular}) = false
+issingular(A::Union{Adjoint,Transpose}) = issingular(parent(A))
 diaganyzero(A) = any(iszero, view(A, diagind(A)))
 
 """

test/runtests.jl

@@ -150,12 +150,12 @@ using ArrayInterface: issingular
         S = Symmetric(R)
         L = UpperTriangular(R)
         U = LowerTriangular(R)
-        @test all(!issingular, [R, S, L, U])
+        @test all(!issingular, [R, S, L, U, U'])
         R[:, 2] .= 0
-        @test all(issingular, [R, L, U])
+        @test all(issingular, [R, L, U, U'])
         @test !issingular(S)
         R[2, :] .= 0
         @test issingular(S)
-        @test all(!issingular, [UnitLowerTriangular(R), UnitUpperTriangular(R)])
+        @test all(!issingular, [UnitLowerTriangular(R), UnitUpperTriangular(R), UnitUpperTriangular(R)'])
     end
 end