Pass dimension for projection factorizations (#139)

Author: dlfivefifty

Project.toml

@@ -1,6 +1,6 @@
 name = "ContinuumArrays"
 uuid = "7ae1f121-cc2c-504b-ac30-9b923412ae5c"
-version = "0.12.1"
+version = "0.12.2"
 
 
 [deps]

src/bases/bases.jl

@@ -297,7 +297,7 @@ _sub_factorize(::Tuple{Any,Any}, (kr,jr)::Tuple{Any,OneTo}, L, dims...; kws...)
 
 # If jr is not OneTo we project
 _sub_factorize(::Tuple{Any,Any}, (kr,jr), L, dims...; kws...) =
-    ProjectionFactorization(factorize(parent(L)[:,OneTo(maximum(jr))]), jr)
+    ProjectionFactorization(factorize(parent(L)[:,OneTo(maximum(jr))], dims...), jr)
 
 _factorize(::SubBasisLayout, L, dims...; kws...) = _sub_factorize(size(parent(L)), parentindices(L), L, dims...; kws...)
 

test/test_splines.jl

@@ -304,9 +304,13 @@ import ContinuumArrays: basis, AdjointBasisLayout, ExpansionLayout, BasisLayout,
             @test factorize(L[:,2:end-1]) isa ContinuumArrays.ProjectionFactorization
             @test factorize(L[:,Base.OneTo(2)]) isa ContinuumArrays.ProjectionFactorization
             @test L[:,1:2] \ x ==  L[:,Base.OneTo(2)] \ x == [1,2]
-            @test L \ [x one(x)] ≈ [L\x L\one(x)]
-            @test factorize(L) \ QuasiOnes(x, Base.OneTo(3)) ≈ L \ QuasiOnes(x, Base.OneTo(3)) ≈ ones(3,3)
-            @test size(factorize(L), 2) == size(L, 2)
+
+            @testset "multiple" begin
+                @test L \ [x one(x)] ≈ [L\x L\one(x)]
+                @test factorize(L) \ QuasiOnes(x, Base.OneTo(3)) ≈ L \ QuasiOnes(x, Base.OneTo(3)) ≈ ones(3,3)
+                @test size(factorize(L), 2) == size(L, 2)
+                @test L \ [x exp.(x)] == L[:,1:size(L,2)] \ [x exp.(x)] == [L\x L\exp.(x)]
+            end
 
             L = LinearSpline(range(0,1; length=10_000))
             x = axes(L,1)