Skip to content

Commit 4633dc2

Browse files
author
bytekeeper
committed
I don't think we want people to subclass this API. Made it final to prevent mistakes.
1 parent cdcea88 commit 4633dc2

File tree

14 files changed

+21
-21
lines changed

14 files changed

+21
-21
lines changed

src/main/java/bwem/Altitude.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public final class Altitude implements Comparable<Altitude> {
2323
public static final Altitude ZERO = new Altitude(0);
2424
private final int val;
2525

26-
public Altitude(final int val) {
26+
Altitude(final int val) {
2727
this.val = val;
2828
}
2929

src/main/java/bwem/AreaId.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public final class AreaId implements Comparable<AreaId> {
2121
public static final AreaId ZERO = new AreaId(0);
2222
private final int val;
2323

24-
public AreaId(final int val) {
24+
AreaId(final int val) {
2525
this.val = val;
2626
}
2727

src/main/java/bwem/AreaInitializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
import static bwem.AreaId.UNINITIALIZED;
2727

28-
class AreaInitializer extends Area {
28+
final class AreaInitializer extends Area {
2929

3030
private static final StaticMarkable staticMarkable = new StaticMarkable();
3131
private final Markable markable;

src/main/java/bwem/Base.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
* Base always belongs to some Area. An Area may contain zero, one or several Bases. Like Areas and
2929
* ChokePoints, the number and the addresses of Base instances remain unchanged.
3030
*/
31-
public class Base {
31+
public final class Base {
3232
private final Area area;
3333
private final List<Mineral> minerals = new ArrayList<>();
3434
private final List<Geyser> geysers = new ArrayList<>();

src/main/java/bwem/CPPath.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* <p>cp.h:68:typedef std::vector<const ChokePoint *> Path; cp.h:168:typedef ChokePoint::Path
2323
* CPPath;
2424
*/
25-
public class CPPath implements Iterable<ChokePoint> {
25+
public final class CPPath implements Iterable<ChokePoint> {
2626

2727
static final CPPath EMPTY_PATH = new CPPath();
2828
private final List<ChokePoint> chokepoints;

src/main/java/bwem/ChokePoint.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
* ChokePoint for each blocking Neutral (only one in the case of stacked blocking Neutral).<br>
4040
* Such ChokePoints are called pseudo ChokePoints and they behave differently in several ways.
4141
*/
42-
public class ChokePoint {
42+
public final class ChokePoint {
4343
private final Graph graph;
4444
private final boolean isPseudo;
4545
private final int index;

src/main/java/bwem/Graph.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public final class Graph {
3535
new ArrayList<>(); // index == ChokePoint::index x ChokePoint::index
3636
private final List<Base> bases = new ArrayList<>();
3737

38-
public Graph(BWMap map) {
38+
Graph(BWMap map) {
3939
this.map = map;
4040
}
4141

src/main/java/bwem/MapData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919
import java.util.ArrayList;
2020
import java.util.List;
2121

22-
public class MapData {
22+
public final class MapData {
2323
private final TilePosition tileSize;
2424
private final WalkPosition walkSize;
2525
private final Position pixelSize;
2626
private final Position center;
2727
private final List<TilePosition> startingLocations;
2828

29-
public MapData(
29+
MapData(
3030
final int tileWidth, final int tileHeight, final List<TilePosition> startingLocations) {
3131

3232
this.tileSize = new TilePosition(tileWidth, tileHeight);

src/main/java/bwem/MiniTile.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
* - The whole process of analysis of a BWMap relies on the walkability information<br>
2929
* from which are derived successively: altitudes, Areas, ChokePoints.
3030
*/
31-
public class MiniTile {
31+
public final class MiniTile {
3232
private static final AreaId blockingCP = new AreaId(Integer.MIN_VALUE);
3333

3434
private Altitude
@@ -38,7 +38,7 @@ public class MiniTile {
3838
areaId; // 0 -> unwalkable ; > 0 -> index of some Area ; < 0 -> some walkable terrain, but
3939
// too small to be part of an Area
4040

41-
public MiniTile() {
41+
MiniTile() {
4242
this.altitude = Altitude.UNINITIALIZED;
4343
this.areaId = UNINITIALIZED;
4444
}

src/main/java/bwem/NeutralData.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,16 @@
1717
import java.util.ArrayList;
1818
import java.util.List;
1919

20-
public class NeutralData {
20+
public final class NeutralData {
2121
private final List<Mineral> minerals;
2222
private final List<Geyser> geysers;
2323
private final List<StaticBuilding> staticBuildings;
2424

25-
public NeutralData(
26-
final BWMap map,
27-
final List<Unit> mineralPatches,
28-
final List<Unit> vespeneGeysers,
29-
final List<Unit> neutralUnits) {
25+
NeutralData(
26+
final BWMap map,
27+
final List<Unit> mineralPatches,
28+
final List<Unit> vespeneGeysers,
29+
final List<Unit> neutralUnits) {
3030
////////////////////////////////////////////////////////////////////////
3131
// BWMap::InitializeNeutrals
3232
////////////////////////////////////////////////////////////////////////

0 commit comments

Comments
 (0)