|
| 1 | +/*- |
| 2 | + * #%L |
| 3 | + * JSQLParser library |
| 4 | + * %% |
| 5 | + * Copyright (C) 2004 - 2026 JSQLParser |
| 6 | + * %% |
| 7 | + * Dual licensed under GNU LGPL 2.1 or Apache License 2.0 |
| 8 | + * #L% |
| 9 | + */ |
| 10 | +package net.sf.jsqlparser.statement.alter; |
| 11 | + |
| 12 | +import static org.junit.jupiter.api.Assertions.*; |
| 13 | +import java.util.ArrayList; |
| 14 | +import java.util.List; |
| 15 | +import java.util.Set; |
| 16 | +import net.sf.jsqlparser.JSQLParserException; |
| 17 | +import net.sf.jsqlparser.expression.Expression; |
| 18 | +import net.sf.jsqlparser.parser.AbstractJSqlParser.Dialect; |
| 19 | +import net.sf.jsqlparser.parser.CCJSqlParserUtil; |
| 20 | +import net.sf.jsqlparser.schema.Column; |
| 21 | +import net.sf.jsqlparser.statement.Statement; |
| 22 | +import net.sf.jsqlparser.statement.create.table.ConstraintAttributes; |
| 23 | +import net.sf.jsqlparser.statement.create.table.CreateTable; |
| 24 | +import net.sf.jsqlparser.statement.create.table.Index; |
| 25 | +import net.sf.jsqlparser.statement.create.table.NotNullConstraint; |
| 26 | +import net.sf.jsqlparser.util.TableDefinitionTraversal; |
| 27 | +import net.sf.jsqlparser.util.TablesNamesFinder; |
| 28 | +import net.sf.jsqlparser.util.deparser.AlterDeParser; |
| 29 | +import net.sf.jsqlparser.util.deparser.ExpressionDeParser; |
| 30 | +import net.sf.jsqlparser.util.deparser.StatementDeParser; |
| 31 | +import net.sf.jsqlparser.util.validation.ValidationContext; |
| 32 | +import net.sf.jsqlparser.util.validation.metadata.DatabaseMetaDataValidation; |
| 33 | +import net.sf.jsqlparser.util.validation.metadata.Named; |
| 34 | +import net.sf.jsqlparser.util.validation.metadata.NamedObject; |
| 35 | +import net.sf.jsqlparser.util.validation.validator.AlterValidator; |
| 36 | +import org.junit.jupiter.api.Test; |
| 37 | +import org.junit.jupiter.params.ParameterizedTest; |
| 38 | +import org.junit.jupiter.params.provider.ValueSource; |
| 39 | + |
| 40 | +class PostgreSqlNotNullConstraintTest { |
| 41 | + @ParameterizedTest |
| 42 | + @ValueSource(strings = {"NOT NULL id", "CONSTRAINT nn NOT NULL id", |
| 43 | + "CONSTRAINT nn NOT NULL id NO INHERIT", "CONSTRAINT \"NN Name\" NOT NULL \"ID\""}) |
| 44 | + void roundTripsCreateAndAlter(String body) throws JSQLParserException { |
| 45 | + for (String sql : new String[] {"CREATE TABLE t (id INT, " + body + ")", |
| 46 | + "ALTER TABLE t ADD " + body + " NOT VALID"}) { |
| 47 | + Statement statement = parse(sql); |
| 48 | + assertEquals(sql, statement.toString()); |
| 49 | + NotNullConstraint constraint = constraint(statement); |
| 50 | + assertEquals(Index.Kind.NOT_NULL, constraint.getKind()); |
| 51 | + assertNotNull(constraint.getColumn()); |
| 52 | + roundTrip(statement); |
| 53 | + } |
| 54 | + } |
| 55 | + |
| 56 | + @Test |
| 57 | + void supportsEditingAndConstruction() throws JSQLParserException { |
| 58 | + Alter alter = |
| 59 | + (Alter) parse("ALTER TABLE t ADD CONSTRAINT nn NOT NULL id NO INHERIT NOT VALID"); |
| 60 | + NotNullConstraint constraint = constraint(alter); |
| 61 | + assertTrue(constraint.isNoInherit()); |
| 62 | + assertTrue(constraint.getConstraintAttributes().isNotValid()); |
| 63 | + constraint.setName("new_nn"); |
| 64 | + constraint.getColumn().setColumnName("other_id"); |
| 65 | + constraint.setNoInherit(false); |
| 66 | + assertEquals("ALTER TABLE t ADD CONSTRAINT new_nn NOT NULL other_id NOT VALID", |
| 67 | + alter.toString()); |
| 68 | + roundTrip(alter); |
| 69 | + ConstraintAttributes attributes = new ConstraintAttributes(); |
| 70 | + attributes.setNotValid(true); |
| 71 | + alter.getAlterExpressions().get(0).setIndex(new NotNullConstraint().withName("nn") |
| 72 | + .withColumn(new Column("id")).withNoInherit(true) |
| 73 | + .withConstraintAttributes(attributes)); |
| 74 | + assertEquals("ALTER TABLE t ADD CONSTRAINT nn NOT NULL id NO INHERIT NOT VALID", |
| 75 | + alter.toString()); |
| 76 | + roundTrip(alter); |
| 77 | + assertEquals(Index.Kind.NOT_NULL, new Index().withType("NOT NULL").getKind()); |
| 78 | + } |
| 79 | + |
| 80 | + @Test |
| 81 | + void visitsTargetColumnAndUsesCustomExpressionDeparser() throws JSQLParserException { |
| 82 | + Alter alter = (Alter) parse("ALTER TABLE t ADD CONSTRAINT nn NOT NULL id"); |
| 83 | + List<Expression> visited = new ArrayList<>(); |
| 84 | + TableDefinitionTraversal.visit(alter.getAlterExpressions().get(0), visited::add, table -> { |
| 85 | + }); |
| 86 | + assertEquals(List.of(constraint(alter).getColumn()), visited); |
| 87 | + CreateTable table = (CreateTable) parse("CREATE TABLE t (id INT, NOT NULL id)"); |
| 88 | + visited.clear(); |
| 89 | + TableDefinitionTraversal.visit(table, visited::add, source -> { |
| 90 | + }); |
| 91 | + assertEquals(List.of(constraint(table).getColumn()), visited); |
| 92 | + assertEquals(Set.of("t"), new TablesNamesFinder().getTables(alter)); |
| 93 | + StringBuilder sql = new StringBuilder(); |
| 94 | + ExpressionDeParser expressions = new ExpressionDeParser() { |
| 95 | + @Override |
| 96 | + public <S> StringBuilder visit(Column column, S context) { |
| 97 | + return getBuilder().append("replacement"); |
| 98 | + } |
| 99 | + }; |
| 100 | + expressions.setBuilder(sql); |
| 101 | + new AlterDeParser(sql, expressions).deParse(alter); |
| 102 | + assertEquals("ALTER TABLE t ADD CONSTRAINT nn NOT NULL replacement", sql.toString()); |
| 103 | + } |
| 104 | + |
| 105 | + @Test |
| 106 | + void validatesNewConstraintAndExistingColumn() throws JSQLParserException { |
| 107 | + List<Named> visited = new ArrayList<>(); |
| 108 | + DatabaseMetaDataValidation metadata = named -> { |
| 109 | + visited.add(named); |
| 110 | + return named.getNamedObject() != NamedObject.constraint; |
| 111 | + }; |
| 112 | + AlterValidator validator = new AlterValidator(); |
| 113 | + validator.setContext(new ValidationContext().setCapabilities(List.of(metadata))); |
| 114 | + validator.validate((Alter) parse("ALTER TABLE t ADD CONSTRAINT nn NOT NULL id NOT VALID")); |
| 115 | + assertTrue(validator.getValidationErrors().isEmpty()); |
| 116 | + assertTrue(visited.stream().anyMatch( |
| 117 | + n -> n.getNamedObject() == NamedObject.column && "id".equals(n.getFqn()))); |
| 118 | + assertTrue(visited.stream().anyMatch( |
| 119 | + n -> n.getNamedObject() == NamedObject.constraint && "nn".equals(n.getFqn()))); |
| 120 | + assertTrue(visited.stream().noneMatch(n -> n.getNamedObject() == NamedObject.index)); |
| 121 | + } |
| 122 | + |
| 123 | + @Test |
| 124 | + void preservesColumnNullabilityAndActionBoundaries() throws JSQLParserException { |
| 125 | + roundTrip(parse("ALTER TABLE t ADD NOT NULL id NOT VALID, ADD COLUMN extra INT")); |
| 126 | + for (String sql : new String[] {"CREATE TABLE t (id INT NOT NULL)", |
| 127 | + "ALTER TABLE t ALTER COLUMN id SET NOT NULL", |
| 128 | + "ALTER TABLE t ALTER COLUMN id DROP NOT NULL"}) { |
| 129 | + assertEquals(sql, CCJSqlParserUtil.parse(sql).toString()); |
| 130 | + roundTrip(parse(sql)); |
| 131 | + } |
| 132 | + } |
| 133 | + |
| 134 | + private static NotNullConstraint constraint(Statement statement) { |
| 135 | + return (NotNullConstraint) (statement instanceof Alter |
| 136 | + ? ((Alter) statement).getAlterExpressions().get(0).getIndex() |
| 137 | + : ((CreateTable) statement).getIndexes().get(0)); |
| 138 | + } |
| 139 | + |
| 140 | + private static Statement parse(String sql) throws JSQLParserException { |
| 141 | + return CCJSqlParserUtil.parse(sql, p -> p.withDialect(Dialect.POSTGRESQL)); |
| 142 | + } |
| 143 | + |
| 144 | + private static void roundTrip(Statement statement) throws JSQLParserException { |
| 145 | + StringBuilder sql = new StringBuilder(); |
| 146 | + statement.accept(new StatementDeParser(sql), null); |
| 147 | + assertEquals(statement.toString(), sql.toString()); |
| 148 | + assertEquals(sql.toString(), parse(sql.toString()).toString()); |
| 149 | + } |
| 150 | +} |
0 commit comments