Skip to content

Commit 8c65dab

Browse files
committed
build: pin file.encoding for the forked test JVMs as well
ParserKeywordsUtilsTest regenerates the .jj in-process and reads it back, so it depends on the default charset the same way the build does. Surefire forks its test JVMs and those do not inherit .mvn/jvm.config, leaving them on the platform default: ParserKeywordsUtilsTest.getAllKeywordsUsingJavaCC ... <<< ERROR! org.javacc.parser.MetaParseException Gradle needs no equivalent: its test workers take their encoding from the daemon, which gradle.properties already pins.
1 parent b5256d4 commit 8c65dab

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

‎pom.xml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -569,11 +569,13 @@
569569
@{jacocoArgLine} is resolved late, after jacoco:prepare-agent has run.
570570
Without it the JaCoCo agent would be dropped and coverage reports empty.
571571
-->
572+
<!-- Forked test JVMs do not inherit .mvn/jvm.config, so pin the encoding here too. -->
572573
<argLine>
573574
@{jacocoArgLine}
574575
--add-opens=java.base/java.lang=ALL-UNNAMED
575576
--add-opens=java.base/java.util=ALL-UNNAMED
576577
-Xmx2G -Xms800m -Xss4m
578+
-Dfile.encoding=UTF-8
577579
</argLine>
578580
</configuration>
579581
</plugin>

0 commit comments

Comments
 (0)