Skip to content

Commit 4ee54d0

Browse files
committed
Drop redundant no-arg constructors flagged by Codacy
Each inner class declared an empty public no-arg constructor as its only constructor, which is redundant — the compiler generates an equivalent default constructor (Codacy PMD UnnecessaryConstructor). Removed both; the grammar and tests that instantiate them with `new ...Clause()` are unaffected. Verified locally: full build + XmlTableTest pass on JDK 17; javap confirms the default constructor is still synthesized. Refs #2326 Signed-off-by: 付典 <fudianchn@gmail.com>
1 parent 6752cc6 commit 4ee54d0

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

src/main/java/net/sf/jsqlparser/expression/XmlTableFunction.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ public static class XmlTablePassingClause extends ASTNodeAccessImpl implements S
4242
private Expression valueExpression;
4343
private String name;
4444

45-
public XmlTablePassingClause() {}
46-
4745
public Expression getValueExpression() {
4846
return valueExpression;
4947
}
@@ -81,8 +79,6 @@ public static class XmlTableColumnDefinition extends ASTNodeAccessImpl implement
8179
private Expression pathExpression;
8280
private Expression defaultExpression;
8381

84-
public XmlTableColumnDefinition() {}
85-
8682
public String getColumnName() {
8783
return columnName;
8884
}

0 commit comments

Comments
 (0)