|
| 1 | +/*- |
| 2 | + * #%L |
| 3 | + * JSQLParser library |
| 4 | + * %% |
| 5 | + * Copyright (C) 2004 - 2026 JSQLParser |
| 6 | + * %% |
| 7 | + * Dual licensed under GNU LGPL 2.1 or Apache License 2.0 |
| 8 | + * #L% |
| 9 | + */ |
| 10 | +package net.sf.jsqlparser.statement.create; |
| 11 | + |
| 12 | +import static org.junit.jupiter.api.Assertions.*; |
| 13 | +import java.util.List; |
| 14 | +import java.util.Set; |
| 15 | +import net.sf.jsqlparser.JSQLParserException; |
| 16 | +import net.sf.jsqlparser.parser.CCJSqlParserUtil; |
| 17 | +import net.sf.jsqlparser.parser.AbstractJSqlParser.Dialect; |
| 18 | +import net.sf.jsqlparser.statement.Statement; |
| 19 | +import net.sf.jsqlparser.statement.alter.Alter; |
| 20 | +import net.sf.jsqlparser.statement.create.table.CreateTable; |
| 21 | +import net.sf.jsqlparser.statement.create.table.ForeignKeyIndex; |
| 22 | +import net.sf.jsqlparser.statement.create.table.Index; |
| 23 | +import net.sf.jsqlparser.util.TablesNamesFinder; |
| 24 | +import net.sf.jsqlparser.util.deparser.StatementDeParser; |
| 25 | +import org.junit.jupiter.api.Test; |
| 26 | +import org.junit.jupiter.params.ParameterizedTest; |
| 27 | +import org.junit.jupiter.params.provider.ValueSource; |
| 28 | + |
| 29 | +class PostgreSqlTemporalConstraintTest { |
| 30 | + @ParameterizedTest |
| 31 | + @ValueSource(strings = {"PRIMARY KEY", "UNIQUE", "UNIQUE NULLS NOT DISTINCT"}) |
| 32 | + void modelsTemporalKeysAcrossCreateAndAlter(String kind) throws JSQLParserException { |
| 33 | + for (String prefix : List.of("CREATE TABLE t (id INT, valid DATERANGE, ", |
| 34 | + "ALTER TABLE t ADD ")) { |
| 35 | + Statement statement = parse(prefix + "CONSTRAINT temporal_key " + kind |
| 36 | + + " (id, valid WITHOUT OVERLAPS) INCLUDE (label) DEFERRABLE INITIALLY DEFERRED" |
| 37 | + + (prefix.startsWith("CREATE") ? ", label TEXT)" : ", ADD COLUMN extra INT")); |
| 38 | + Index index = index(statement); |
| 39 | + assertEquals("temporal_key", index.getName()); |
| 40 | + assertTrue(statement.toString().contains("CONSTRAINT temporal_key")); |
| 41 | + assertEquals(2, index.getColumns().size()); |
| 42 | + assertFalse(index.getColumns().get(0).isWithoutOverlaps()); |
| 43 | + Index.ColumnParams last = index.getColumns().get(1); |
| 44 | + assertTrue(last.isWithoutOverlaps()); |
| 45 | + assertEquals("valid", last.getColumnName()); |
| 46 | + assertNull(last.getOperatorClass()); |
| 47 | + assertEquals(List.of("label"), index.getIncludeColumns()); |
| 48 | + roundTrip(statement); |
| 49 | + last.setWithoutOverlaps(false); |
| 50 | + assertFalse(statement.toString().contains("WITHOUT OVERLAPS")); |
| 51 | + roundTrip(statement); |
| 52 | + } |
| 53 | + } |
| 54 | + |
| 55 | + @ParameterizedTest |
| 56 | + @ValueSource(strings = {"", " (id, PERIOD valid)", " (id, PERIOD \"Valid Range\")"}) |
| 57 | + void sharesReferencingAndReferencedPeriodLists(String referenced) throws JSQLParserException { |
| 58 | + for (String prefix : List.of("CREATE TABLE t (id INT, valid DATERANGE, ", |
| 59 | + "ALTER TABLE t ADD ")) { |
| 60 | + Statement statement = |
| 61 | + parse(prefix + "FOREIGN KEY (id, PERIOD valid) REFERENCES app.parent" |
| 62 | + + referenced + " ON DELETE NO ACTION ON UPDATE NO ACTION" |
| 63 | + + (prefix.startsWith("CREATE") ? ")" : ", ADD COLUMN extra INT")); |
| 64 | + ForeignKeyIndex foreign = (ForeignKeyIndex) index(statement); |
| 65 | + assertFalse(foreign.getColumns().get(0).isPeriod()); |
| 66 | + assertTrue(foreign.getColumns().get(1).isPeriod()); |
| 67 | + assertEquals("valid", foreign.getColumns().get(1).getColumnName()); |
| 68 | + assertEquals(!referenced.isEmpty(), foreign.getReference().isUsingPeriod()); |
| 69 | + assertEquals(Set.of("t", "app.parent"), new TablesNamesFinder().getTables(statement)); |
| 70 | + roundTrip(statement); |
| 71 | + foreign.getColumns().get(1).setPeriod(false); |
| 72 | + foreign.getReference().setUsingPeriod(false); |
| 73 | + assertFalse(statement.toString().contains("PERIOD")); |
| 74 | + roundTrip(statement); |
| 75 | + } |
| 76 | + } |
| 77 | + |
| 78 | + @Test |
| 79 | + void retainsQuotedAndUnquotedIdentifiersAndLegacyProjections() throws JSQLParserException { |
| 80 | + CreateTable table = (CreateTable) parse("CREATE TABLE t (id INT, period DATERANGE, " |
| 81 | + + "FOREIGN KEY (id, period) REFERENCES p(id, period))"); |
| 82 | + ForeignKeyIndex foreign = (ForeignKeyIndex) index(table); |
| 83 | + assertFalse(foreign.getColumns().get(1).isPeriod()); |
| 84 | + assertFalse(foreign.getReference().isUsingPeriod()); |
| 85 | + roundTrip(table); |
| 86 | + table = (CreateTable) parse("CREATE TABLE t (id INT, \"PERIOD\" DATERANGE, " |
| 87 | + + "FOREIGN KEY (id, PERIOD \"PERIOD\") REFERENCES p(id, PERIOD \"PERIOD\"))"); |
| 88 | + foreign = (ForeignKeyIndex) index(table); |
| 89 | + assertEquals(List.of("id", "\"PERIOD\""), foreign.getReferencedColumnNames()); |
| 90 | + foreign.getReferencedColumnNames().set(1, "replacement"); |
| 91 | + assertTrue(table.toString().contains("PERIOD replacement")); |
| 92 | + roundTrip(table); |
| 93 | + assertEquals(2, CCJSqlParserUtil.parseStatements(table + "; SELECT 1", |
| 94 | + p -> p.withDialect(Dialect.POSTGRESQL)).size()); |
| 95 | + } |
| 96 | + |
| 97 | + @Test |
| 98 | + void preservesNamedUniqueConstraintsWithAndWithoutTemporalKeys() throws JSQLParserException { |
| 99 | + Statement ordinary = parse("ALTER TABLE t ADD CONSTRAINT uq UNIQUE (id)"); |
| 100 | + assertEquals("uq", index(ordinary).getName()); |
| 101 | + assertEquals("ALTER TABLE t ADD CONSTRAINT uq UNIQUE (id)", ordinary.toString()); |
| 102 | + roundTrip(ordinary); |
| 103 | + Statement temporal = parse("ALTER TABLE t ADD CONSTRAINT uq " |
| 104 | + + "UNIQUE (id, valid WITHOUT OVERLAPS)"); |
| 105 | + assertEquals("uq", index(temporal).getName()); |
| 106 | + assertTrue(index(temporal).getColumns().get(1).isWithoutOverlaps()); |
| 107 | + roundTrip(temporal); |
| 108 | + } |
| 109 | + |
| 110 | + @Test |
| 111 | + void keepsOrdinaryIndexesAndCrossDialectForeignKeys() throws JSQLParserException { |
| 112 | + String mysql = "CREATE TABLE t (id INT, FOREIGN KEY (id) REFERENCES p (id))"; |
| 113 | + assertNotNull(CCJSqlParserUtil.parse(mysql)); |
| 114 | + assertEquals("valid WITHOUT OVERLAPS", |
| 115 | + new Index.ColumnParams("valid").withWithoutOverlaps(true).toString()); |
| 116 | + assertEquals("PERIOD valid", new Index.ColumnParams("valid").withPeriod(true).toString()); |
| 117 | + assertThrows(JSQLParserException.class, |
| 118 | + () -> parse("CREATE INDEX ix ON t (id, valid WITHOUT OVERLAPS)")); |
| 119 | + } |
| 120 | + |
| 121 | + @ParameterizedTest |
| 122 | + @ValueSource(strings = {"UNIQUE (valid WITHOUT OVERLAPS, id)", |
| 123 | + "PRIMARY KEY (id, valid WITHOUT)", |
| 124 | + "UNIQUE (id, valid WITHOUT OVERLAPS WITHOUT OVERLAPS)", |
| 125 | + "FOREIGN KEY (PERIOD valid, id) REFERENCES p(id, valid)", |
| 126 | + "FOREIGN KEY (id, PERIOD valid) REFERENCES p(PERIOD valid, id)"}) |
| 127 | + void rejectsMalformedTemporalMarkers(String constraint) { |
| 128 | + assertThrows(JSQLParserException.class, |
| 129 | + () -> parse("CREATE TABLE t (id INT, valid DATERANGE, " + constraint + ")")); |
| 130 | + } |
| 131 | + |
| 132 | + private static Index index(Statement statement) { |
| 133 | + return statement instanceof CreateTable ? ((CreateTable) statement).getIndexes().get(0) |
| 134 | + : ((Alter) statement).getAlterExpressions().get(0).getIndex(); |
| 135 | + } |
| 136 | + |
| 137 | + private static Statement parse(String sql) throws JSQLParserException { |
| 138 | + return CCJSqlParserUtil.parse(sql, p -> p.withDialect(Dialect.POSTGRESQL)); |
| 139 | + } |
| 140 | + |
| 141 | + private static void roundTrip(Statement statement) throws JSQLParserException { |
| 142 | + StringBuilder out = new StringBuilder(); |
| 143 | + statement.accept(new StatementDeParser(out)); |
| 144 | + assertEquals(statement.toString(), out.toString()); |
| 145 | + assertEquals(out.toString(), parse(out.toString()).toString()); |
| 146 | + } |
| 147 | +} |
0 commit comments