[#38] Add node 10/12 windows builds (#41)

* [#38] add node 12 windows build

* [#38] upgrade yarn to 1.22.0

* [#38] try installing NVS in before_install

* [#38] move nvs into maybe-install-node.sh and disable non windows build jobs for now

* [#38] fix .travis.yml

* [#38] use nvs 1.5.4

* [#38] build only windows for now

* [#38] use TRAVIS_NODE_VERSION for nvs

* [#38] add os: win32 to package.json

* [#38] add win32 to rustup

* [#38] exec node-pre-gyp from the cwd

* [#38] fix typo

* [#38] re-enable Linux - Node 10 build

* [#38] exec node-pre-gyp from TLD

* [#38] try ./node_modules again

* Early exist windows testing

* Use fully qualified path to pre-gyp binary

* Remove windows test build script

* Try to stop Windows builds from hanging

* Re-enable all build combinations

* [#38] only install msvc rust target if on windows; clean up

* [#38] only install msvc rust target if on windows attempt 2

* [#38] only install msvc rust target if on windows (attempt 3)

* [#38] update version to 0.7.1; update README

* Remove old commented out line in build file

Co-authored-by: Ernie Turner <ernie.turner@gmail.com>

Author: clintfred

.travis.yml

@@ -55,7 +55,28 @@ jobs:
               - TRAVIS_NODE_VERSION="12"
               - SKIP_DEPLOY=0
           if: tag =~ /^\d+\.\d+\.\d+/ OR branch = master OR type = pull_request
-
+        - name: "Windows - Node 10"
+          os: windows
+          env:
+              # Stop Windows builds from hanging after completion https://travis-ci.community/t/timeout-after-build-finished-and-succeeded/1336
+              - YARN_GPG=no
+              - TRAVIS_NODE_VERSION="10"
+              - SKIP_DEPLOY=0
+          install: 
+              - rustup target add x86_64-pc-windows-msvc
+              - source .travis_scripts/maybe-install-node.sh
+          if: tag =~ /^\d+\.\d+\.\d+/ OR branch = master OR type = pull_request
+        - name: "Windows - Node 12"
+          os: windows
+          env:
+              # Stop Windows builds from hanging after completion https://travis-ci.community/t/timeout-after-build-finished-and-succeeded/1336
+              - YARN_GPG=no
+              - TRAVIS_NODE_VERSION="12"
+              - SKIP_DEPLOY=0
+          install: 
+              - rustup target add x86_64-pc-windows-msvc
+              - source .travis_scripts/maybe-install-node.sh
+          if: tag =~ /^\d+\.\d+\.\d+/ OR branch = master OR type = pull_request
         # Publish to npm only on release tag
         - stage: publish
           name: "Publish to npm"
@@ -76,6 +97,7 @@ jobs:
 before_install:
     - ./.travis_scripts/maybe-start-docker.sh
 
+# this install not used by windows builds
 install:
     - source .travis_scripts/maybe-install-node.sh
 

.travis_scripts/maybe-install-node.sh

@@ -3,10 +3,17 @@
 # Installs correct node and yarn versions if we aren't doing a docker build.
 
 if [ -z "${IMAGE}" ] ; then
+
+	# install node via NVS -- supports Linux, OS X, and Windows
+	git clone --branch v1.5.4 --depth 1 https://github.com/jasongin/nvs ~/.nvs
+	. ~/.nvs/nvs.sh
+	nvs --version
+	nvs add $TRAVIS_NODE_VERSION
+	nvs use $TRAVIS_NODE_VERSION
+	node --version
+
     # install our own yarn to make things work on osx
-    curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.10.1
+    curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.22.0
     export PATH=$HOME/.yarn/bin:$PATH
 
-    # install our own nodejs to get a reasonable version if outside docker
-    rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm install $TRAVIS_NODE_VERSION
 fi

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.7.1
+
+### Changed
+
+- Added support for Node 10/12 on Windows
+
 ## 0.7.0
 
 ### Breaking Changes

README.md

@@ -14,6 +14,8 @@ This library uses the [Neon Bindings](https://www.neon-bindings.com) toolchain t
 | Linux x64 - glibc     | ✓       | ✓       |
 | Linux x64 - musl-libc | ✓       | ✓       |
 | OSX x64               | ✓       | ✓       |
+| Windows x64           | ✓       | ✓       |
+| Windows x64           | ✓       | ✓       |
 
 ## Install
 

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@ironcorelabs/recrypt-node-binding",
-    "version": "0.7.0",
+    "version": "0.7.1",
     "description": "Bindings to allow the recrypt-rs library to work via NodeJS.",
     "repository": {
         "type": "git",
@@ -16,7 +16,8 @@
     },
     "os": [
         "darwin",
-        "linux"
+        "linux",
+        "win32"
     ],
     "cpu": [
         "x64"

publish.js

@@ -52,7 +52,9 @@ fs.writeFileSync("./dist/package.json", JSON.stringify(npmPackageJson, null, 2))
 
 shell.mkdir("./bin-package");
 shell.cp("./native/index.node", "./bin-package");
-shell.exec("./node_modules/.bin/node-pre-gyp package");
+//Use a fully qualified path to pre-gyp binary for Windows support
+const cwd = shell.pwd().toString();
+shell.exec(`${cwd}/node_modules/node-pre-gyp/bin/node-pre-gyp package`);
 var tgz = shell.exec("find ./build -name *.tar.gz");
 shell.cp(tgz, "./bin-package/");
 shell.pushd("./dist");