Skip to content

Commit 47e5484

Browse files
committed
Merge remote-tracking branch 'origin/main' into main
2 parents 3796c7c + 737f45d commit 47e5484

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

graphgen/models/searcher/db/ncbi_searcher.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ def _infer_molecule_type_detail(accession: Optional[str], gene_type: Optional[in
8989
if accession:
9090
if accession.startswith(("NM_", "XM_")):
9191
return "mRNA"
92-
elif accession.startswith(("NC_", "NT_")):
92+
if accession.startswith(("NC_", "NT_")):
9393
return "genomic DNA"
94-
elif accession.startswith(("NR_", "XR_")):
94+
if accession.startswith(("NR_", "XR_")):
9595
return "RNA"
96-
elif accession.startswith("NG_"):
96+
if accession.startswith("NG_"):
9797
return "genomic region"
9898
# Fallback: infer from gene type if available
9999
if gene_type is not None:
@@ -215,7 +215,7 @@ def _extract_metadata_from_genbank(result: dict, accession: str):
215215
"""Extract metadata from GenBank format (title, features, organism, etc.)."""
216216
with Entrez.efetch(db="nuccore", id=accession, rettype="gb", retmode="text") as handle:
217217
record = SeqIO.read(handle, "genbank")
218-
218+
219219
result["title"] = record.description
220220
result["molecule_type_detail"] = (
221221
"mRNA" if accession.startswith(("NM_", "XM_")) else
@@ -238,7 +238,7 @@ def _extract_metadata_from_genbank(result: dict, accession: str):
238238

239239
if not result.get("organism") and 'organism' in record.annotations:
240240
result["organism"] = record.annotations['organism']
241-
241+
242242
return result
243243

244244
def _extract_sequence_from_fasta(result: dict, accession: str):
@@ -249,7 +249,10 @@ def _extract_sequence_from_fasta(result: dict, accession: str):
249249
result["sequence"] = str(fasta_record.seq)
250250
result["sequence_length"] = len(fasta_record.seq)
251251
except Exception as fasta_exc:
252-
logger.warning("Failed to extract sequence from accession %s using FASTA format: %s", accession, fasta_exc)
252+
logger.warning(
253+
"Failed to extract sequence from accession %s using FASTA format: %s",
254+
accession, fasta_exc
255+
)
253256
result["sequence"] = None
254257
result["sequence_length"] = None
255258
return result

scripts/search/build_db/build_rna_blast_db.sh

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,13 @@ if [ "${DB_SELECTION}" = "list" ]; then
4444
echo "Available RNAcentral database subsets:"
4545
echo ""
4646
echo "Fetching list from RNAcentral FTP..."
47-
curl -s "${RNACENTRAL_BY_DB_URL}/" | \
48-
grep -oE '<a href="[^"]*\.fasta">' | \
47+
listing=$(curl -s "${RNACENTRAL_BY_DB_URL}/")
48+
echo "${listing}" | \
49+
grep -oE '<a href="[^\"]*\.fasta">' | \
4950
sed 's/<a href="//;s/">//' | \
5051
sort | \
5152
while read db; do
52-
size=$(curl -s "${RNACENTRAL_BY_DB_URL}/" | grep -A 1 "${db}" | grep -oE '[0-9.]+[GMK]' | head -1 || echo "unknown")
53+
size=$(echo "${listing}" | grep -A 1 "${db}" | grep -oE '[0-9.]+[GMK]' | head -1 || echo "unknown")
5354
echo " - ${db%.fasta}: ${size}"
5455
done
5556
echo ""
@@ -76,16 +77,14 @@ wget -q "${RELEASE_NOTES_URL}" 2>/dev/null || {
7677

7778
if [ -f "${RELEASE_NOTES}" ]; then
7879
# Try to extract version from release notes (first line usually contains version info)
79-
RELEASE=$(head -1 "${RELEASE_NOTES}" | grep -oE '[0-9]+\.[0-9]+' | head -1 | tr -d '.' || date +%Y%m%d)
80-
if [ -z "${RELEASE}" ] || [ "${RELEASE}" = "$(date +%Y%m%d)" ]; then
81-
RELEASE=$(date +%Y%m%d)
82-
echo "Using date as release identifier: ${RELEASE}"
83-
else
84-
echo "RNAcentral release: ${RELEASE}"
85-
fi
86-
else
80+
RELEASE=$(head -1 "${RELEASE_NOTES}" | grep -oE '[0-9]+\.[0-9]+' | head -1 | tr -d '.')
81+
fi
82+
83+
if [ -z "${RELEASE}" ]; then
8784
RELEASE=$(date +%Y%m%d)
8885
echo "Using date as release identifier: ${RELEASE}"
86+
else
87+
echo "RNAcentral release: ${RELEASE}"
8988
fi
9089

9190
# Download RNAcentral FASTA file

0 commit comments

Comments
 (0)