Skip to content

Accept tuple value for out keyword in ufuncs #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 12, 2025
Merged

Accept tuple value for out keyword in ufuncs #2664

merged 9 commits into from
Nov 12, 2025

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 12, 2025 •
edited
Loading

This PR adds support for the out keyword to accept a tuple passed to a ufunc.
The documentation of every function is updated to reflect that change.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 12, 2025
@antonwolfy antonwolfy self-assigned this Nov 12, 2025
@antonwolfy antonwolfy mentioned this pull request Nov 12, 2025
Open
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_51 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

@antonwolfy antonwolfy marked this pull request as ready for review November 12, 2025 13:48
vlad-perevezentsev
vlad-perevezentsev approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@coveralls
Copy link
Collaborator

coveralls commented Nov 12, 2025

Coverage Status

coverage: 81.455% (+0.002%) from 81.453%
when pulling cddd015 on allow-passing-tuple-as-out-kw-to-ufuncs
into 7eed7da on master.

@antonwolfy antonwolfy merged commit 486b00d into master Nov 12, 2025
96 of 97 checks passed
@antonwolfy antonwolfy deleted the allow-passing-tuple-as-out-kw-to-ufuncs branch November 12, 2025 14:57
github-actions bot added a commit that referenced this pull request Nov 12, 2025
@github-actions
Accept tuple value for out keyword in ufuncs (#2664)
5f06aba 
This PR adds support for the `out` keyword to accept a tuple passed to a
ufunc.
The documentation of every function is updated to reflect that change. 486b00d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev