Merge pull request #2004 from IntelPython/backport-gh-2002

Backport gh-2002

Author: ndgrigorian

CHANGELOG.md

@@ -59,6 +59,7 @@ A number of adjustments were also made to improve performance of `dpctl` reducti
 * Corrected uses of NumPy constructors with `tensor.usm_ndarray` inputs in test suite [gh-1968](https://github.com/IntelPython/dpctl/pull/1968)
 * Fixed array API namespace inspection utilities showing `complex128` as a valid dtype on devices without double precision and `device` keywords not working with `dpctl.SyclQueue` or filter strings [gh-1979](https://github.com/IntelPython/dpctl/pull/1979)
 * Fixed a bug in `test_sycl_device_interface.cpp` which would cause compilation to fail with Clang version 20.0 [gh-1989](https://github.com/IntelPython/dpctl/pull/1989)
+* Fixed memory leaks in smart-pointer-managed USM temporaries in synchronizing kernel calls [gh-2002](https://github.com/IntelPython/dpctl/pull/2002)
 
 ### Maintenance
 

dpctl/tensor/libtensor/source/accumulators.cpp

@@ -210,7 +210,7 @@ std::size_t py_mask_positions(const dpctl::tensor::usm_ndarray &mask,
             sycl::event::wait(host_task_events);
 
             // ensure deleter of smart pointer is invoked with GIL released
-            shape_strides_owner.release();
+            shape_strides_owner.reset(nullptr);
         }
         throw std::runtime_error("Unexpected error");
     }
@@ -231,7 +231,7 @@ std::size_t py_mask_positions(const dpctl::tensor::usm_ndarray &mask,
 
         sycl::event::wait(host_task_events);
         // ensure deleter of smart pointer is invoked with GIL released
-        shape_strides_owner.release();
+        shape_strides_owner.reset(nullptr);
     }
 
     return total_set;
@@ -367,7 +367,7 @@ std::size_t py_cumsum_1d(const dpctl::tensor::usm_ndarray &src,
             sycl::event::wait(host_task_events);
 
             // ensure USM deleter is called with GIL released
-            shape_strides_owner.release();
+            shape_strides_owner.reset(nullptr);
         }
         throw std::runtime_error("Unexpected error");
     }
@@ -387,7 +387,7 @@ std::size_t py_cumsum_1d(const dpctl::tensor::usm_ndarray &src,
         sycl::event::wait(host_task_events);
 
         // ensure USM deleter is called with GIL released
-        shape_strides_owner.release();
+        shape_strides_owner.reset(nullptr);
     }
 
     return total;

dpctl/tensor/libtensor/source/copy_numpy_ndarray_into_usm_ndarray.cpp

@@ -325,7 +325,7 @@ void copy_numpy_ndarray_into_usm_ndarray(
             dst_offset, depends, {copy_shape_ev});
 
         // invoke USM deleter in smart pointer while GIL is held
-        shape_strides_owner.release();
+        shape_strides_owner.reset(nullptr);
     }
 
     return;