📝 handle unit testing with reflection (#376)

Author: alyezz

CHANGELOG.md

@@ -88,4 +88,3 @@
 * Added new OnReportSubmitHandler API
 * Fixed linking script
 * Api Name Changes
-

android/src/test/java/com/instabug/reactlibrary/RNInstabugReactnativeModuleTest.java

@@ -2,39 +2,30 @@
 
 import android.os.Handler;
 import android.os.Looper;
-
-import com.facebook.react.bridge.Arguments;
-import com.facebook.react.bridge.JavaOnlyArray;
-import com.facebook.react.bridge.JavaOnlyMap;
-import com.facebook.react.bridge.WritableMap;
-import com.instabug.bug.BugReporting;
-
 import android.os.SystemClock;
 import android.util.Log;
 
+import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.Callback;
-import com.facebook.react.bridge.ReadableArray;
+import com.facebook.react.bridge.JavaOnlyArray;
+import com.facebook.react.bridge.JavaOnlyMap;
 import com.facebook.react.bridge.WritableArray;
+import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.bridge.WritableNativeArray;
+import com.instabug.bug.BugReporting;
 import com.instabug.chat.Chats;
 import com.instabug.chat.Replies;
 import com.instabug.crash.CrashReporting;
-import com.instabug.featuresrequest.ActionType;
 import com.instabug.featuresrequest.FeatureRequests;
 import com.instabug.library.Feature;
 import com.instabug.library.Instabug;
 import com.instabug.library.InstabugColorTheme;
 import com.instabug.library.InstabugCustomTextPlaceHolder;
 import com.instabug.library.InstabugState;
-
-import com.instabug.library.model.Report;
 import com.instabug.library.ui.onboarding.WelcomeMessage;
 import com.instabug.library.visualusersteps.State;
-import com.instabug.survey.OnDismissCallback;
-import com.instabug.survey.OnShowCallback;
 import com.instabug.survey.Surveys;
 
-import org.json.JSONArray;
 import org.json.JSONObject;
 import org.junit.Assert;
 import org.junit.Before;
@@ -49,22 +40,18 @@
 import org.powermock.modules.junit4.PowerMockRunner;
 import org.powermock.reflect.Whitebox;
 
-import java.lang.reflect.Method;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Locale;
 import java.util.Map;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
 
-import static com.instabug.reactlibrary.utils.InstabugUtil.getMethod;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.anyLong;
-import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.verify;
 import static org.powermock.api.mockito.PowerMockito.doAnswer;
 import static org.powermock.api.mockito.PowerMockito.mock;
-import static org.powermock.api.mockito.PowerMockito.verifyPrivate;
 import static org.powermock.api.mockito.PowerMockito.when;
 
 @RunWith(PowerMockRunner.class)
@@ -120,9 +107,8 @@ public Boolean answer(InvocationOnMock invocation) throws Throwable {
     }
 
     @Test
-    public void givenString$sendHandledJSCrash_whenQuery_thenShouldCallNativeApiWithArgs() {
+    public void givenString$sendHandledJSCrash_whenQuery_thenShouldCallNativeApiWithArgs() throws Exception {
 
-        try {
             JSONObject json = mock(JSONObject.class);
             PowerMockito.whenNew(JSONObject.class).withArguments("exception").thenReturn(json);
 
@@ -131,22 +117,13 @@ public Boolean answer(InvocationOnMock invocation) throws Throwable {
             // when
             rnModule.sendHandledJSCrash("exception");
             // then
-            PowerMockito.verifyStatic(VerificationModeFactory.times(1));
             JSONObject jsonObject = new JSONObject("exception");
-            Method method = getMethod(Class.forName("com.instabug.crash.CrashReporting"), "reportException", JSONObject.class, boolean.class, Report.class);
-            if (method != null) {
-                method.invoke(null, jsonObject, true, null);
-            }
-        } catch (Exception e) {
-            e.printStackTrace();
-            e.getCause();
-        }
+            PowerMockito.verifyPrivate(CrashReporting.class, VerificationModeFactory.times(1)).invoke("reportException", jsonObject, true);
     }
 
     @Test
-    public void givenString$sendJSCrash_whenQuery_thenShouldCallNativeApiWithArgs() {
+    public void givenString$sendJSCrash_whenQuery_thenShouldCallNativeApiWithArgs() throws Exception {
 
-        try {
             JSONObject json = mock(JSONObject.class);
             PowerMockito.whenNew(JSONObject.class).withArguments("exception").thenReturn(json);
 
@@ -155,16 +132,8 @@ public Boolean answer(InvocationOnMock invocation) throws Throwable {
             // when
             rnModule.sendJSCrash("exception");
             // then
-            PowerMockito.verifyStatic(VerificationModeFactory.times(1));
             JSONObject jsonObject = new JSONObject("exception");
-            Method method = getMethod(Class.forName("com.instabug.crash.CrashReporting"), "reportException", JSONObject.class, boolean.class, Report.class);
-            if (method != null) {
-                method.invoke(null, jsonObject, false, null);
-            }
-        } catch (Exception e) {
-            e.printStackTrace();
-            e.getCause();
-        }
+            PowerMockito.verifyPrivate(CrashReporting.class, VerificationModeFactory.times(1)).invoke("reportException", jsonObject, false);
     }
 
     /********Instabug*********/