Refactored parseErrorStack RN Check

Author: shehabeldeenibrahim

modules/CrashReporting.js

@@ -24,17 +24,8 @@ export default {
    * @param errorObject Error object to be sent to Instabug's servers
    */
   reportJSException: function(errorObject) {
-    let jsStackTrace;
-    if (Platform.hasOwnProperty("constants")) {
-      // RN version >= 0.63
-      if (Platform.constants.reactNativeVersion.minor >= 64)
-        // RN version >= 0.64 -> Stacktrace as string
-        jsStackTrace = InstabugUtils.parseErrorStack(errorObject.stack);
-      // RN version == 0.63 -> Stacktrace as Object
-      else jsStackTrace = InstabugUtils.parseErrorStack(errorObject);
-    }
-    // RN version < 0.63 -> Stacktrace as Object
-    else jsStackTrace = InstabugUtils.parseErrorStack(errorObject);
+    let jsStackTrace = InstabugUtils.getStackTrace(errorObject);
+    
     var jsonObject = {
       message: errorObject.name + ' - ' + errorObject.message,
       os: Platform.OS,

utils/InstabugUtils.js

@@ -40,6 +40,21 @@ function getFullRoute(state) {
   }
 }
 
+export const getStackTrace = (e) => {
+  let jsStackTrace;
+  if (Platform.hasOwnProperty("constants")) {
+    // RN version >= 0.63
+    if (Platform.constants.reactNativeVersion.minor >= 64)
+      // RN version >= 0.64 -> Stacktrace as string
+      jsStackTrace = parseErrorStackLib(e.stack);
+    // RN version == 0.63 -> Stacktrace as string
+    else jsStackTrace = parseErrorStackLib(e);
+  }
+  // RN version < 0.63 -> Stacktrace as string
+  else jsStackTrace = parseErrorStackLib(e);
+  return jsStackTrace;
+};
+
 export const isOnReportHandlerSet = () => {
   return _isOnReportHandlerSet;
 };
@@ -52,17 +67,7 @@ export const captureJsErrors = () => {
   }
 
   function errorHandler(e, isFatal) {
-    let jsStackTrace;
-    if (Platform.hasOwnProperty("constants")) {
-      // RN version >= 0.63
-      if (Platform.constants.reactNativeVersion.minor >= 64)
-        // RN version >= 0.64 -> Stacktrace as string
-        jsStackTrace = parseErrorStackLib(e.stack);
-      // RN version == 0.63 -> Stacktrace as Object
-      else jsStackTrace = parseErrorStackLib(e);
-    }
-    // RN version < 0.63 -> Stacktrace as Object
-    else jsStackTrace = parseErrorStackLib(e);
+    let jsStackTrace = getStackTrace(e);
 
     //JSON object to be sent to the native SDK
     var jsonObject = {
@@ -101,5 +106,6 @@ export default {
   setOnReportHandler,
   isOnReportHandlerSet,
   getActiveRouteName,
-  getFullRoute
+  getFullRoute,
+  getStackTrace,
 };