🎨 Reformat the structure of the linking and unlinking scripts

Author: salmatarzi

link.rb

@@ -5,59 +5,65 @@
 	puts('xcodeproj doesn\'t exist')
 	Kernel.exit(0)
 end
-require 'fileutils'
 
 # Replace these with your values
 current_path = Dir.pwd
 project_path = Dir.glob("#{current_path}/ios/*.xcodeproj").first
 file_name = File.basename(project_path, ".xcodeproj")
-project_location = './ios/'+file_name+'.xcodeproj'
+project_location = "./ios/#{file_name}.xcodeproj"
 target_name = file_name
 framework_root = '../node_modules/instabug-reactnative/ios'
 framework_name = 'Instabug.framework'
 
 INSTABUG_PHASE_NAME = "Strip Frameworks"
+
 INSTABUG_PHASE_SCRIPT = <<-SCRIPTEND
 bash "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Instabug.framework/Instabug.bundle/strip-frameworks.sh"
   SCRIPTEND
 
 # Get useful variables
 project = Xcodeproj::Project.open(project_location)
 frameworks_group = project.groups.find { |group| group.display_name == 'Frameworks' }
-if frameworks_group == nil 
-    frameworks_group = project.new_group('Frameworks')
-end
+frameworks_group = project.new_group('Frameworks') if frameworks_group == nil 
 target = project.targets.find { |target| target.to_s == target_name }
 frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'FrameworksBuildPhase' }
 
 # Add new "Embed Frameworks" build phase to target
-embed_frameworks_build_phase = project.new(Xcodeproj::Project::Object::PBXCopyFilesBuildPhase)
-embed_frameworks_build_phase.name = 'Embed Frameworks'
-embed_frameworks_build_phase.symbol_dst_subfolder_spec = :frameworks
-target.build_phases << embed_frameworks_build_phase
+embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Frameworks'}
+if embed_frameworks_build_phase == nil
+  embed_frameworks_build_phase = project.new(Xcodeproj::Project::Object::PBXCopyFilesBuildPhase)
+  embed_frameworks_build_phase.name = 'Embed Frameworks'
+  embed_frameworks_build_phase.symbol_dst_subfolder_spec = :frameworks
+  target.build_phases << embed_frameworks_build_phase
+end
 
 # Add framework search path to target
 ['Debug', 'Release'].each do |config|
-  paths = ['$(inherited', framework_root]
-  if target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'] == nil
-    target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'] = paths
-  elsif target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'].kind_of?(Array)
-    target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'] << framework_root unless target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'].include? framework_root
-  else 
-    paths = [target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'], framework_root]
-    target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'] = paths
-  end
+  paths = ['$(inherited)', framework_root]
+  framework_search_paths = target.build_settings(config)['FRAMEWORK_SEARCH_PATHS']
+  
+  framework_search_paths ||= ['$(inherited)']
+  framework_search_paths = [framework_search_paths] unless framework_search_paths.is_a?(Array)
+  framework_search_paths << framework_root unless framework_search_paths.include? framework_root
+
+  target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'] = framework_search_paths
 end
 
 # Add framework to target as "Embedded Frameworks"
-framework_ref = frameworks_group.new_file("#{framework_root}/#{framework_name}")
-build_file = embed_frameworks_build_phase.add_file_reference(framework_ref)
-frameworks_build_phase.add_file_reference(framework_ref)
-build_file.settings = { 'ATTRIBUTES' => ['CodeSignOnCopy', 'RemoveHeadersOnCopy'] }
+framework_ref = frameworks_group.files.find { |file_reference| file_reference.path == "#{framework_root}/#{framework_name}"}
+if framework_ref == nil
+  framework_ref = frameworks_group.new_file("#{framework_root}/#{framework_name}")
+  build_file = embed_frameworks_build_phase.add_file_reference(framework_ref)
+  frameworks_build_phase.add_file_reference(framework_ref)
+  build_file.settings = { 'ATTRIBUTES' => ['CodeSignOnCopy', 'RemoveHeadersOnCopy'] }
+end
 
 #Add New Run Script Phase to Build Phases
-phase = target.new_shell_script_build_phase(INSTABUG_PHASE_NAME)
-phase.shell_script = INSTABUG_PHASE_SCRIPT
+shell_script_build_phase = target.shell_script_build_phases.find { |build_phase| build_phase.to_s == INSTABUG_PHASE_NAME }
+if shell_script_build_phase == nil
+  phase = target.new_shell_script_build_phase(INSTABUG_PHASE_NAME)
+  phase.shell_script = INSTABUG_PHASE_SCRIPT
+end
 
 # Save Xcode project
 project.save

unlink.rb

@@ -5,13 +5,12 @@
 	puts('xcodeproj doesn\'t exist')
 	Kernel.exit(0)
 end
-require 'fileutils'
 
 # Replace these with your values
 current_path = Dir.pwd
 project_path = Dir.glob("#{current_path}/ios/*.xcodeproj").first
 file_name = File.basename(project_path, ".xcodeproj")
-project_location = './ios/'+file_name+'.xcodeproj'
+project_location = "./ios/#{file_name}.xcodeproj"
 target_name = file_name
 framework_root = '../node_modules/instabug-reactnative/ios'
 framework_name = 'Instabug.framework'
@@ -26,7 +25,7 @@
 
 # Remove "Embed Frameworks" build phase to target
 embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Frameworks'}
-target.build_phases.delete(embed_frameworks_build_phase)
+target.build_phases.delete(embed_frameworks_build_phase) if embed_frameworks_build_phase
 
 # Remove framework search path from target
 ['Debug', 'Release'].each do |config|
@@ -36,11 +35,11 @@
 # Remove framework from target from "Embedded Frameworks"
 framework_ref = frameworks_group.files.find { |file_reference| file_reference.path == "#{framework_root}/#{framework_name}"}
 frameworks_build_phase.remove_file_reference(framework_ref)
-framework_ref.remove_from_project
+framework_ref.remove_from_project if framework_ref
 
 #Delete New Run Script Phase from Build Phases
 shell_script_build_phase = target.shell_script_build_phases.find { |build_phase| build_phase.to_s == INSTABUG_PHASE_NAME }
-target.build_phases.delete(shell_script_build_phase)
+target.build_phases.delete(shell_script_build_phase) if shell_script_build_phase
 
 # Save Xcode project
 project.save