Merge pull request #173 from Instabug/feature/replies-notification-string-keys

[INSD-5205] Feature/Add replies notification string keys

Author: Ali Abdelfattah

CHANGELOG.md

@@ -1,5 +1,6 @@
 ## v9.1.9 (2021-05-11)
 
+* Adds support for overriding the replies notification string values through `repliesNotificationTeamName`, `repliesNotificationReplyButton`, `repliesNotificationDismissButton`
 * Removes the use of `android:requestLegacyExternalStorage` attribute on Android
 
 ## v9.1.8 (2021-02-17)

android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java

@@ -189,6 +189,9 @@ static void registerCustomTextPlaceHolderKeysArgs(Map<String, Object> args) {
         args.put("CustomTextPlaceHolderKey.betaWelcomeMessageFinishStepContent", InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_FINISH_STEP_CONTENT);
         args.put("CustomTextPlaceHolderKey.liveWelcomeMessageTitle", InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_TITLE);
         args.put("CustomTextPlaceHolderKey.liveWelcomeMessageContent", InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_CONTENT);
+        args.put("CustomTextPlaceHolderKey.repliesNotificationTeamName", InstabugCustomTextPlaceHolder.Key.CHATS_TEAM_STRING_NAME);
+        args.put("CustomTextPlaceHolderKey.repliesNotificationReplyButton", InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_REPLY_BUTTON);
+        args.put("CustomTextPlaceHolderKey.repliesNotificationDismissButton", InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_DISMISS_BUTTON);
     }
 
     static void registerInstabugReportTypesArgs(Map<String, Object> args) {

android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java

@@ -283,6 +283,9 @@ private List<InstabugCustomTextPlaceHolder.Key> getCurrentlySupportedKeysBySDK()
         keys.add(InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_FINISH_STEP_CONTENT);
         keys.add(InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_TITLE);
         keys.add(InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_CONTENT);
+        keys.add(InstabugCustomTextPlaceHolder.Key.CHATS_TEAM_STRING_NAME);
+        keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_REPLY_BUTTON);
+        keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_DISMISS_BUTTON);
         return keys;
     }
 
@@ -329,6 +332,9 @@ private List<InstabugCustomTextPlaceHolder.Key> getAllCustomTextPlaceHolderKeys(
         keys.add(InstabugCustomTextPlaceHolder.Key.SURVEYS_WELCOME_SCREEN_SUBTITLE);
         keys.add(InstabugCustomTextPlaceHolder.Key.SURVEYS_WELCOME_SCREEN_BUTTON);
         keys.add(InstabugCustomTextPlaceHolder.Key.REQUEST_FEATURE);
+        keys.add(InstabugCustomTextPlaceHolder.Key.CHATS_TEAM_STRING_NAME);
+        keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_REPLY_BUTTON);
+        keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_DISMISS_BUTTON);
         return keys;
     }
 }

ios/Classes/InstabugFlutterPlugin.m

@@ -900,6 +900,10 @@ + (NSDictionary *)constants {
       @"CustomTextPlaceHolderKey.liveWelcomeMessageTitle": kIBGLiveWelcomeMessageTitle,
       @"CustomTextPlaceHolderKey.liveWelcomeMessageContent": kIBGLiveWelcomeMessageContent,
 
+      @"CustomTextPlaceHolderKey.repliesNotificationTeamName": kIBGTeamStringName,
+      @"CustomTextPlaceHolderKey.repliesNotificationReplyButton": kIBGReplyButtonTitleStringName,
+      @"CustomTextPlaceHolderKey.repliesNotificationDismissButton": kIBGDismissButtonTitleStringName,
+
       @"ReportType.bug": @(IBGBugReportingReportTypeBug),
       @"ReportType.feedback": @(IBGBugReportingReportTypeFeedback),
       @"ReportType.question": @(IBGBugReportingReportTypeQuestion),

lib/Instabug.dart

@@ -76,7 +76,10 @@ enum CustomTextPlaceHolderKey {
   betaWelcomeMessageFinishStepTitle,
   betaWelcomeMessageFinishStepContent,
   liveWelcomeMessageTitle,
-  liveWelcomeMessageContent
+  liveWelcomeMessageContent,
+  repliesNotificationTeamName,
+  repliesNotificationReplyButton,
+  repliesNotificationDismissButton
 }
 
 enum ReproStepsMode { enabled, disabled, enabledWithNoScreenshots }