Fix mixin warnings, mostly about overwrite reasons

- Fixed warning about elevating access to onUpdateWalkingPlayer from
  private to public.
- Added @Reason doc strings to the four overwrite methods.

Author: LeafHacker

src/main/java/me/zero/client/load/mixin/MixinBlock.java

@@ -53,6 +53,7 @@ private void canCollideCheck(IBlockState state, boolean hitIfLiquid, CallbackInf
     }
 
     /**
+     * @reason the overwritten method is only one line, we need to overwrite to mutate the AABB and pass params into the event constructor
      * @author Brady
      */
     @Overwrite

src/main/java/me/zero/client/load/mixin/MixinEntityPlayerSP.java

@@ -87,10 +87,11 @@ private void move(AbstractClientPlayer player, MoverType type, double x, double
     }
 
     /**
+     * @reason In addition to firing pre and post events, we also want to override some position values (prefixed with p).
      * @author Brady
      */
     @Overwrite
-    public void onUpdateWalkingPlayer() {
+    private void onUpdateWalkingPlayer() {
         EntityPlayerSP _this = (EntityPlayerSP) (Object) this;
 
         MotionUpdateEvent pre = new MotionUpdateEvent(EventState.PRE);
@@ -110,6 +111,8 @@ public void onUpdateWalkingPlayer() {
 
         if (this.isCurrentViewEntity()) {
 
+            // Override vanilla defaults of _tis.posX, etc
+            // This is why we need to overwrite the method body.
             double pX = pre.getX();
             double pY = pre.getY();
             double pZ = pre.getZ();

src/main/java/me/zero/client/load/mixin/MixinNettyPacketDecoder.java

@@ -27,6 +27,7 @@ public class MixinNettyPacketDecoder {
     @Shadow @Final private EnumPacketDirection direction;
 
     /**
+     * @reason we need to wait until the packet is built and then pass it (and the connection state) to the event constructor
      * @author Brady
      */
     @Overwrite
@@ -39,6 +40,7 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf in, List<Object> out) t
         EnumConnectionState state = ctx.channel().attr(NetworkManager.PROTOCOL_ATTRIBUTE_KEY).get();
         Packet<?> packet = state.getPacket(this.direction, packetId);
 
+        // We need the packet to create our Event, so we have to overwrite the method body
         PacketEvent event = new PacketEvent.Decode(packet, state);
         ClientAPI.EVENT_BUS.post(event);
         packet = event.getPacket();

src/main/java/me/zero/client/load/mixin/MixinNettyPacketEncoder.java

@@ -26,6 +26,7 @@ public class MixinNettyPacketEncoder {
     @Shadow @Final private EnumPacketDirection direction;
 
     /**
+     * @reason mostly because we need to mutate msg, but also so that we can pass the connection state to the event constructor
      * @author Brady
      */
     @Overwrite
@@ -37,6 +38,7 @@ protected void encode(ChannelHandlerContext ctx, Packet<?> msg, ByteBuf out) thr
             LOGGER.debug(RECEIVED_PACKET_MARKER, "OUT: [{}:{}] {}", state, packetId, msg.getClass().getName());
         }
 
+        // We need the state and we plan to mutate the msg, hence the overwrite
         PacketEvent event = new PacketEvent.Encode(msg, state);
         ClientAPI.EVENT_BUS.post(event);
         msg = event.getPacket();