Constructors for ImageRegion #71
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackermd
requested changes
May 11, 2021
Collaborator
hackermd
left a comment
hackermd
left a comment
There was a problem hiding this comment.
Nice! Just a minor comment regarding terminology.
Comment on lines
+653
to
+654
| xc: float, | ||
| yc: float, |
Collaborator
There was a problem hiding this comment.
We should avoid x and y here and use row and col instead, because the axis of the coordinate system (pixel matrix) are Rows and Columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hackermd
This is my working branch for implementing more user-friendly constructors for
ImageRegion. For now justImageRegionand notImageRegion3Dis implemented. This PR is just an example - as discussed we may instead choose a different path such as implementing as sub-classes. However the logic in this branch should be re-usable, it may just end up being refactored