Right now grid allows user to put igx-grid-excel-style-filtering tag in it. When this is done grid saves the IgxGridExcelStyleFilteringComponent components in excelStyleFilteringComponents @ContentChildren collection, but the component is not generated in grid markup. Then grid uses only the first found child to show it when ESF should be shown. This is the first issue - why using the first one and not let say the sixth one?
When showing the inline added ESF grid now uses outlet to attach the ESF to the grid. If outlet is removed overlay service will try to position an element ref which has no parent element. This will end up attaching the ESF to the DOM outside the grid.
Additionally IgxPivotGridComponent has in its markup IgxGridExcelStyleFilteringComponent. Pivot grid unlike grid, is generating the IgxGridExcelStyleFilteringComponent in its markup. In order to hide it, as it should not be visible initially, ESF is put in a div which is hidden by default. Now when we show ESF in pivot grid it is moved to the outlet and this allow it to be shown. However, if we remove the outlet ESF will be shown inside the hidden div and it will not be visible.
To fix both issues we may:
- first option - ensure ESF is generated inside the gird and is hidden always not only in pivot grid. This could be achieved by putting it in container with fix position and z-index less than 0. However, customers should be forced to add ESF to the grids in same way.
- second option - remove the possibility to add ESF as child to the grid and allow customizing it by some properties.
Right now grid allows user to put
igx-grid-excel-style-filteringtag in it. When this is done grid saves theIgxGridExcelStyleFilteringComponentcomponents inexcelStyleFilteringComponents@ContentChildrencollection, but the component is not generated in grid markup. Then grid uses only the first found child to show it when ESF should be shown. This is the first issue - why using the first one and not let say the sixth one?When showing the inline added ESF grid now uses outlet to attach the ESF to the grid. If outlet is removed overlay service will try to position an element ref which has no parent element. This will end up attaching the ESF to the DOM outside the grid.
Additionally
IgxPivotGridComponenthas in its markupIgxGridExcelStyleFilteringComponent. Pivot grid unlike grid, is generating theIgxGridExcelStyleFilteringComponentin its markup. In order to hide it, as it should not be visible initially, ESF is put in a div which is hidden by default. Now when we show ESF in pivot grid it is moved to the outlet and this allow it to be shown. However, if we remove the outlet ESF will be shown inside the hidden div and it will not be visible.To fix both issues we may: