Restore support for parameters as vectors (#263)

Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>

Author: emstoudenmire

Project.toml

@@ -1,7 +1,7 @@
 name = "ITensorNetworks"
 uuid = "2919e153-833c-4bdc-8836-1ea460a35fc7"
 authors = ["Matthew Fishman <mfishman@flatironinstitute.org>, Joseph Tindall <jtindall@flatironinstitute.org> and contributors"]
-version = "0.15.3"
+version = "0.15.4"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"

src/solvers/insert.jl

@@ -12,8 +12,9 @@ function insert!(region_iter, local_tensor; normalize = false, set_orthogonal_re
         indsTe = inds(psi[first(region)])
         tags = ITensors.tags(psi, e)
 
+        trunc_kwargs = truncation_parameters(region_iter.which_sweep; region_kwargs(factorize, region_iter)...)
         U, C, spectrum = factorize(
-            local_tensor, indsTe; tags, region_kwargs(factorize, region_iter)...
+            local_tensor, indsTe; tags, trunc_kwargs...
         )
 
         @preserve_graph psi[first(region)] = U

src/solvers/subspace/densitymatrix.jl

@@ -29,8 +29,9 @@ function subspace_expand!(
     isnothing(a) && return region_iter, local_state
     basis_size = prod(dim.(uniqueinds(A, C)))
 
+    trunc_kwargs = truncation_parameters(region_iter.which_sweep; eigen_kwargs...)
     expanded_maxdim = compute_expansion(
-        dim(a), basis_size; expansion_factor, maxexpand, eigen_kwargs.maxdim
+        dim(a), basis_size; expansion_factor, maxexpand, trunc_kwargs.maxdim
     )
     expanded_maxdim <= 0 && return region_iter, local_state
 
@@ -48,7 +49,7 @@ function subspace_expand!(
         sqrt_rho = conj_proj_A(sqrt_rho)
     end
     rho = sqrt_rho * dag(noprime(sqrt_rho))
-    D, U = eigen(rho; eigen_kwargs..., ishermitian = true)
+    D, U = eigen(rho; trunc_kwargs..., ishermitian = true)
 
     Uproj(T) = (T - prime(A, a) * (dag(prime(A, a)) * T))
     for _ in 1:north_pass

test/solvers/test_eigsolve.jl

@@ -53,11 +53,22 @@ include("utilities/tree_graphs.jl")
 
     #
     # Test 1-site DMRG with subspace expansion
+    # and cutoff and maxdim as vectors of values
     #
     nsites = 1
     nsweeps = 5
+    factorize_kwargs = (; cutoff = [1.0e-5, 1.0e-6], maxdim = [8, 16, 32])
     extract!_kwargs = (; subspace_algorithm = "densitymatrix")
     E, psi = dmrg(H, psi0; extract!_kwargs, factorize_kwargs, nsites, nsweeps, outputlevel)
     (outputlevel >= 1) && println("1-site+subspace DMRG energy = ", E)
     @test E ≈ Ex atol = 1.0e-5
+
+    #
+    # Test passing cutoff and maxdim as a vector of values
+    #
+    nsites = 2
+    factorize_kwargs = (; cutoff = [1.0e-5, 1.0e-6], maxdim = [8, 16, 32])
+    E, psi = dmrg(H, psi0; factorize_kwargs, nsites, nsweeps, outputlevel)
+    (outputlevel >= 1) && println("2-site DMRG energy = ", E)
+    @test E ≈ Ex atol = 1.0e-5
 end