Skip to content

Commit 08bc949

Browse files
committed
[ITB-1393] Support different labels for options and external artifacts per validation type
1 parent c7875c2 commit 08bc949

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

jsonvalidator-web/src/main/java/eu/europa/ec/itb/json/web/UploadController.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import eu.europa.ec.itb.validation.commons.FileInfo;
1010
import eu.europa.ec.itb.validation.commons.LocalisationHelper;
1111
import eu.europa.ec.itb.validation.commons.artifact.ExternalArtifactSupport;
12+
import eu.europa.ec.itb.validation.commons.artifact.TypedValidationArtifactInfo;
1213
import eu.europa.ec.itb.validation.commons.artifact.ValidationArtifactCombinationApproach;
1314
import eu.europa.ec.itb.validation.commons.artifact.ValidationArtifactInfo;
1415
import eu.europa.ec.itb.validation.commons.error.ValidatorException;
@@ -19,6 +20,7 @@
1920
import eu.europa.ec.itb.validation.commons.web.locale.CustomLocaleResolver;
2021
import org.apache.commons.io.FileUtils;
2122
import org.apache.commons.lang3.StringUtils;
23+
import org.apache.commons.lang3.tuple.Pair;
2224
import org.slf4j.Logger;
2325
import org.slf4j.LoggerFactory;
2426
import org.springframework.beans.factory.BeanFactory;
@@ -76,6 +78,14 @@ public ModelAndView upload(@PathVariable("domain") String domain, HttpServletReq
7678
var localisationHelper = new LocalisationHelper(config, localeResolver.resolveLocale(request, response, config, appConfig));
7779
attributes.put(PARAM_LOCALISER, localisationHelper);
7880
attributes.put(PARAM_HTML_BANNER_EXISTS, localisationHelper.propertyExists("validator.bannerHtml"));
81+
attributes.put(PARAM_LABEL_CONFIG, getDynamicLabelConfiguration(localisationHelper, config, Collections.emptyList(),
82+
List.of(
83+
Pair.of("validator.label.includeExternalArtefacts", "externalIncludeText"),
84+
Pair.of("validator.label.externalArtefactsTooltip", "externalIncludeTooltip"),
85+
Pair.of("validator.label.externalSchemaLabel", "external."+TypedValidationArtifactInfo.DEFAULT_TYPE+".label"),
86+
Pair.of("validator.label.externalSchemaPlaceholder", "external."+ TypedValidationArtifactInfo.DEFAULT_TYPE+".placeholder")
87+
)
88+
));
7989
return new ModelAndView(VIEW_UPLOAD_FORM, attributes);
8090
}
8191

jsonvalidator-web/src/main/resources/templates/uploadForm.html

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,11 @@
1616
configure({
1717
externalArtifactFileLabel: [[${localiser.localise('validator.label.optionContentFile')}]],
1818
externalArtifactURILabel: [[${localiser.localise('validator.label.optionContentURI')}]],
19-
externalArtifactSettings: {
20-
default: {
21-
filePlaceholder: [[${localiser.localise('validator.label.externalSchemaPlaceholder')}]],
22-
}
23-
},
2419
codeTypeObj: {name: "javascript", json: true},
2520
isMinimalUI: [[${minimalUI}]],
2621
artifactTypes: ['default'],
27-
externalArtifacts: externalArtifacts
22+
externalArtifacts: externalArtifacts,
23+
labels: [(${labelConfig})]
2824
});
2925
</script>
3026
<script th:inline="javascript" th:if="${reportData}">

0 commit comments

Comments
 (0)