tests

Author: DanailPenev

packages/openapi-to-graphql/package.json

@@ -62,7 +62,7 @@
     "build": "tsc --project ../../tsconfig.build.json",
     "guru-load": "node test/evaluation/load_apis_guru.js",
     "guru-test": "DEBUG=preprocessing,translation node test/evaluation/eval_apis_guru.js",
-    "test": "jest --runInBand --detectOpenHandles -t 'Optionally use queryString'"
+    "test": "jest --runInBand --detectOpenHandles"
   },
   "husky": {
     "hooks": {

packages/openapi-to-graphql/test/example_api6.test.ts

@@ -396,3 +396,41 @@ test('Handle no response schema', () => {
     })
   })
 })
+
+/**
+ * GET /arrayInQueryParameters with and without the useQueryString requestOption
+ *
+ * The default behaviour is to add indexed parameters, i.e. a[0]=x&a[1]=y.
+ * The querystring behaviour (which can be made configurable in the future) is a=x&a=y
+ */
+test('Optionally use queryString', () => {
+  const query = `{
+    arrayInQueryParameters(ids: ["a", "b"])
+  }`
+
+  // Use default settings
+  const promise = graphql(createdSchema, query).then((result) => {
+    expect(result.data).toEqual({
+      arrayInQueryParameters: encodeURI('ids[0]=a&ids[1]=b')
+    })
+  })
+
+  // Set useQueryString to true
+  const options: Options<any, any, any> = {
+    requestOptions: {
+      useQueryString: true
+    }
+  }
+
+  const promise2 = openAPIToGraphQL
+    .createGraphQLSchema(oas, options)
+    .then(({ schema, report }) => {
+      return graphql(schema, query).then((result) => {
+        expect(result.data).toEqual({
+          arrayInQueryParameters: encodeURI('ids=a&ids=b')
+        })
+      })
+    })
+
+  return Promise.all([promise, promise2])
+})

packages/openapi-to-graphql/test/example_api6_server.js

@@ -57,6 +57,13 @@ function startServer(PORT) {
     }
   )
 
+  app.get(
+    '/api/arrayInQueryParameters',
+    (req, res) => {
+      res.send(req.originalUrl.split('?')[1])
+    }
+  )
+
   function stringifyRussianDolls(russianDoll) {
     if (!typeof russianDoll.name === 'string') {
       return ''

packages/openapi-to-graphql/test/fixtures/example_oas6.json

@@ -416,6 +416,36 @@
           }
         }
       }
+    },
+    "/arrayInQueryParameters": {
+      "get": {
+        "description": "Takes an array as GET query parameter",
+        "responses": {
+          "200": {
+            "description": "Success",
+            "content": {
+              "text/html": {
+                "schema": {
+                  "type": "string"
+                }
+              }
+            }
+          }
+        },
+        "parameters": [
+          {
+            "name": "ids",
+            "in": "query",
+            "required": false,
+            "schema": {
+              "type": "array",
+              "items": {
+                "type": "string"
+              }
+            }
+          }
+        ]
+      }
     }
   },
   "components": {