fix(getSkyBlockProfiles): fetching garden & museum while either are disabled (#684)

* fix: museum and garden options

* pnpm lint

* only fetch when options explicitly set to true

Co-authored-by: Jacob <kathund@proton.me>

* simplify ternary

* also respect options in fetchSkyblockProfile

* fix(getSkyBlockProfile/s):  garden & museum types

---------

Co-authored-by: Jacob <kathund@proton.me>

Author: BridgeSenseDev

src/API/getSkyBlockProfile.ts

@@ -12,8 +12,8 @@ class getSkyBlockProfile extends Endpoint {
     const res = await this.client.requestHandler.request(`/skyblock/profile?profile=${profileId}`, options);
     if (res.options.raw) return res;
     if (!res.data.profile) throw new Error(Errors.NO_SKYBLOCK_PROFILES);
-    const garden = await this.handleGettingSkyBlockGarden(res.data.profile.profile_id);
-    const museum = await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id);
+    const garden = options?.museum ? await this.handleGettingSkyBlockGarden(res.data.profile.profile_id) : undefined;
+    const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id) : undefined;
     const parsedProfile = new SkyBlockProfile(res.data.profile, { uuid: null, garden, museum });
     return parsedProfile;
   }

src/API/getSkyBlockProfiles.ts

@@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint {
     if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES);
     const profiles: Map<SkyBlockProfileName | 'UNKNOWN', SkyBlockProfile> = new Map();
     for (const profile of res.data.profiles) {
-      const garden = await this.handleGettingSkyBlockGarden(profile.profile_id);
-      const museum = await this.handleGettingSkyBlockMuseum(profile.profile_id);
+      const garden = options?.garden ? await this.handleGettingSkyBlockGarden(profile.profile_id) : undefined;
+      const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : undefined;
       const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum });
       profiles.set(parsedProfile.profileName, parsedProfile);
     }