diff --git a/.claude/review-state.json b/.claude/review-state.json index b21a0b9..721d65e 100644 --- a/.claude/review-state.json +++ b/.claude/review-state.json @@ -1,6 +1,6 @@ { - "last_run": "2026-05-26T00:55:00Z", - "last_commit": "5083c52b64190381eadbb9f0c13b42e52c358a5a", + "last_run": "2026-05-26T11:15:00Z", + "last_commit": "81f8735d167b597ed7a7a88cc7f89ba0b440b07d", "filed": [ { "issue": 8, @@ -14,6 +14,19 @@ "evidence_quality": 10 }, "timestamp": "2026-05-26T00:55:00Z" + }, + { + "issue": 24, + "title": "[REVIEW] CLI: getVersion() uses require() in ESM module — --version and --help always display 0.0.0", + "finding": "getVersion() in src/cli.ts:20-26 calls require('../package.json') in an ESM module ('type':'module' + module:NodeNext). require is undefined in ESM, so the catch block always returns '0.0.0'. Confirmed: node dist/cli.js --version outputs 0.0.0 instead of 1.0.1.", + "score": 5.65, + "score_breakdown": { + "user_impact": 6, + "security_severity": 2, + "implementation_effort": 9, + "evidence_quality": 10 + }, + "timestamp": "2026-05-26T11:15:00Z" } ], "runner_ups": [ @@ -52,6 +65,18 @@ "score": 7.9, "reason_not_filed": "duplicate of open issue #5", "timestamp": "2026-05-26T00:55:00Z" + }, + { + "finding": "Permissions-Policy tests: 4 assertions in test/analyzer.test.ts fail on HEAD (81f8735) due to merge regression — 3 checkPermissionsPolicy tests expect score 10 from partial fixture; grade boundaries A+ test fixture uses camera=() only (score 5 not 10), giving 85% not 90%.", + "score": 7.4, + "reason_not_filed": "duplicate of open issue #15 (filed same day by earlier review session)", + "timestamp": "2026-05-26T11:15:00Z" + }, + { + "finding": "CSP maxScore is 30 but maximum achievable score for any non-empty CSP is 20 (no positive bonus points exist); the 10-point gap inflates the denominator and caps the overall percentage at 90% even for a perfectly configured site.", + "score": 5.55, + "reason_not_filed": "lower score than filed finding; no existing issue found but deprioritized", + "timestamp": "2026-05-26T11:15:00Z" } ], "clean_areas": [ @@ -59,6 +84,9 @@ "tsconfig.json strict mode is enabled", "CI workflows (ci.yml, publish.yml, auto-tag.yml) are sound", "X-Content-Type-Options check (rules.ts:93-104) — values correctly validated", - "X-Frame-Options check (rules.ts:73-91) — accepts DENY/SAMEORIGIN and CSP frame-ancestors fallback as expected" + "X-Frame-Options check (rules.ts:73-91) — accepts DENY/SAMEORIGIN and CSP frame-ancestors fallback as expected", + "fetch.ts timeout implementation (AbortController + clearTimeout) is correct", + "analyzer.ts grade boundaries (toGrade) match documented grading scale", + "index.ts analyze() correctly dispatches URL strings vs header objects" ] } diff --git a/package-lock.json b/package-lock.json index 65db0c6..72d1b93 100644 --- a/package-lock.json +++ b/package-lock.json @@ -637,9 +637,6 @@ "arm" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -654,9 +651,6 @@ "arm" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -671,9 +665,6 @@ "arm64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -688,9 +679,6 @@ "arm64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -705,9 +693,6 @@ "loong64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -722,9 +707,6 @@ "loong64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -739,9 +721,6 @@ "ppc64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -756,9 +735,6 @@ "ppc64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -773,9 +749,6 @@ "riscv64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -790,9 +763,6 @@ "riscv64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -807,9 +777,6 @@ "s390x" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -824,9 +791,6 @@ "x64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -841,9 +805,6 @@ "x64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [