fix static analysis hint provided by IntelliJ

Author: Gubaer

src/main/java/org/openstreetmap/josm/plugins/scripting/graalvm/GraalVMFacadeFactory.java

@@ -3,9 +3,6 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-import static org.openstreetmap.josm.tools.I18n.tr;
-import static java.text.MessageFormat.format;
-
 public class GraalVMFacadeFactory {
     static private final  Logger logger = Logger.getLogger(GraalVMFacadeFactory.class.getName());
 

src/main/java/org/openstreetmap/josm/plugins/scripting/graalvm/RequireFunction.java

@@ -139,16 +139,13 @@ private String loadModuleSourceFromJarEntry(@NotNull URI uri)
     private String loadModuleSource(@NotNull URI uri) throws IOException {
         Objects.requireNonNull(uri);
         final String scheme = uri.getScheme().toLowerCase();
-        switch(scheme) {
-            case "file":
-                return loadModuleSourceFromFile(uri);
-            case "jar":
-                return loadModuleSourceFromJarEntry(uri);
-            default:
-                throw new IllegalArgumentException(format(
-                    "unsupported type of module URI, file URI required. Got ''{0}''", uri
-                ));
-        }
+        return switch (scheme) {
+            case "file" -> loadModuleSourceFromFile(uri);
+            case "jar" -> loadModuleSourceFromJarEntry(uri);
+            default -> throw new IllegalArgumentException(format(
+            "unsupported type of module URI, file URI required. Got ''{0}''", uri
+            ));
+        };
     }
 
     private String wrapModuleSource(@NotNull String moduleID,

src/main/java/org/openstreetmap/josm/plugins/scripting/graalvm/TypeResolveFunction.java

@@ -25,8 +25,8 @@ public Value apply(String className) {
         if (className == null || !className.startsWith(basePackageName)) {
             if (logger.isLoggable(Level.FINE)) {
                 logger.log(Level.FINE, format(
-                    "Couldn't lookup a java class in the plugin jar. Class name is null or doesn't belong " +
-                    "to the plugin package. className='{0}'", className
+                    "Couldn''t lookup a java class in the plugin jar. Class name is null or doesn''t belong " +
+                    "to the plugin package. className=''{0}''", className
                 ));
             }
             return null;
@@ -37,7 +37,7 @@ public Value apply(String className) {
         } catch (ClassNotFoundException e) {
             if (logger.isLoggable(Level.FINE)) {
                 logger.log(Level.FINE, format(
-                    "Couldn't lookup a java class in the plugin jar. className='{0}'", className
+                    "Couldn''t lookup a java class in the plugin jar. className=''{0}''", className
                 ), e);
             }
             return null;

src/main/java/org/openstreetmap/josm/plugins/scripting/model/RelativePath.java

@@ -119,7 +119,7 @@ public class RelativePath {
                 MessageFormat.format("path must not be absolute, got ''{0}''", path)
             );
         }
-        if (path.getNameCount() == 1 && "".equals(path.getName(0).toString())) {
+        if (path.getNameCount() == 1 && path.getName(0).toString().isEmpty()) {
             return EMPTY;
         }
         final List<String> segments = new ArrayList<>();

src/main/java/org/openstreetmap/josm/plugins/scripting/model/ScriptEngineDescriptor.java

@@ -38,7 +38,7 @@ public enum ScriptEngineType {
 
         /**
          * Infers the script engine type from preference value. The value is
-         * a string <code>type/engineId</code>. This methods decodes the
+         * a string <code>type/engineId</code>. This method decodes the
          * component <code>type</code>. Replies <code>null</code> if no type
          * can be inferred.
          * <p>
@@ -138,9 +138,7 @@ static public ScriptEngineDescriptor buildFromPreferences(final String preferenc
                 // don't lowercase. Lookup in ScriptEngineManager could be
                 // case-sensitive
                 engineId = engineId.trim();
-                logger.log(Level.FINE, MessageFormat.format(
-                    "buildFromPreferences: engineId={1}",
-                    engineId));
+                logger.log(Level.FINE, MessageFormat.format("buildFromPreferences: engineId={0}", engineId));
                 if (!JSR223ScriptEngineProvider.getInstance()
                         .hasEngineWithName(engineId)) {
                     logger.warning(tr("preference with key ''{0}''"