From 11dc363fd4e36f3c8cad63af77812cc432776dac Mon Sep 17 00:00:00 2001 From: Thiyagu K Date: Thu, 30 Oct 2025 10:30:12 +0000 Subject: [PATCH] Chore: Support non-HNS buckets in moveObjectAtomic Removed HNS-only restriction comments. Restructured tests for non-HNS coverage. --- storage/src/move_object_atomic.php | 2 +- storage/test/ObjectsTest.php | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/storage/src/move_object_atomic.php b/storage/src/move_object_atomic.php index 059ad7d2a1..3b76cbfc80 100644 --- a/storage/src/move_object_atomic.php +++ b/storage/src/move_object_atomic.php @@ -27,7 +27,7 @@ use Google\Cloud\Storage\StorageClient; /** - * Move an object to a new name within HNS-enabled bucket. + * Move an object to a new name within bucket. * * @param string $bucketName The name of your Cloud Storage bucket. * (e.g. 'my-bucket') diff --git a/storage/test/ObjectsTest.php b/storage/test/ObjectsTest.php index 5cf9ab3f3a..4679d565e9 100644 --- a/storage/test/ObjectsTest.php +++ b/storage/test/ObjectsTest.php @@ -153,11 +153,9 @@ public function testManageObject() public function testMoveObjectAtomic() { - $bucketName = self::$bucketName . '-hns'; $objectName = 'test-object-' . time(); $newObjectName = $objectName . '-moved'; - $bucket = self::$storage->createBucket($bucketName, [ - 'hierarchicalNamespace' => ['enabled' => true], + $bucket = self::$storage->createBucket(self::$bucketName, [ 'iamConfiguration' => ['uniformBucketLevelAccess' => ['enabled' => true]] ]); @@ -165,7 +163,7 @@ public function testMoveObjectAtomic() $this->assertTrue($object->exists()); $output = self::runFunctionSnippet('move_object_atomic', [ - $bucketName, + self::$bucketName, $objectName, $newObjectName ]); @@ -173,9 +171,9 @@ public function testMoveObjectAtomic() $this->assertEquals( sprintf( 'Moved gs://%s/%s to gs://%s/%s' . PHP_EOL, - $bucketName, + self::$bucketName, $objectName, - $bucketName, + self::$bucketName, $newObjectName ), $output