ci(metadata, analytics): migrate to new CI (#4004)

* ci(metadata/flexible): migrate to new CI

* migrate esmodule

* add other appengine migration

* module

* move working tests to dev

Author: glasnt

.github/config/nodejs-dev.jsonc

@@ -85,6 +85,8 @@
     "appengine/hello-world/flexible_nodejs16_and_earlier",
     "appengine/hello-world/standard",
     "appengine/memcached",
+    "appengine/analytics",
+    "appengine/metadata/flexible",
     "appengine/metadata/flexible_nodejs16_and_earlier",
     "appengine/metadata/standard",
     "appengine/pubsub",

.github/config/nodejs-prod.jsonc

@@ -76,8 +76,6 @@
 
     // TODO: fix these
     "ai-platform/snippets", // PERMISSION_DENIED: Permission denied: Consumer 'projects/undefined' has been suspended.
-    "appengine/analytics", // [ERR_REQUIRE_ESM]: require() of ES Module
-    "appengine/metadata/flexible", // [ERR_REQUIRE_ESM]: require() of ES Module
     "automl", // (untested) FAILED_PRECONDITION: Google Cloud AutoML Natural Language was retired on March 15, 2024. Please migrate to Vertex AI instead
     "cloud-sql/mysql/mysql", // (untested) Error: expected 200 "OK", got 500 "Internal Server Error"
     "cloud-sql/mysql/mysql2", // (untested) Error: Cannot find module './connect-connector-with-iam-authn.js'

appengine/analytics/app.js

@@ -15,8 +15,8 @@
 'use strict';
 
 // [START gae_flex_analytics_track_event]
-const express = require('express');
-const fetch = require('node-fetch');
+import express from 'express';
+import fetch from 'node-fetch';
 
 const app = express();
 app.enable('trust proxy');
@@ -77,4 +77,4 @@ app.listen(PORT, () => {
 
 // [END gae_flex_analytics_track_event]
 
-module.exports = app;
+export default app;

appengine/analytics/package.json

@@ -9,6 +9,7 @@
     "type": "git",
     "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
   },
+  "type": "module",
   "engines": {
     "node": "20.x"
   },

appengine/analytics/test/app.test.js

@@ -1,6 +1,19 @@
-const supertest = require('supertest');
-const path = require('path');
-const app = require(path.join(__dirname, '../', 'app.js'));
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+import supertest from 'supertest';
+import app from '../app.js';
 
 describe('gae_flex_analytics_track_event', () => {
   it('should be listening', async () => {

appengine/metadata/flexible/package.json

@@ -9,6 +9,7 @@
     "type": "git",
     "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
   },
+  "type": "module",
   "engines": {
     "node": ">= 18.x.x"
   },

appengine/metadata/flexible/server.js

@@ -15,8 +15,8 @@
 'use strict';
 
 // [START gae_flex_metadata]
-const express = require('express');
-const fetch = require('node-fetch');
+import express from 'express';
+import fetch from 'node-fetch';
 
 const app = express();
 app.enable('trust proxy');
@@ -58,4 +58,4 @@ app.listen(PORT, () => {
   console.log('Press Ctrl+C to quit.');
 });
 // [END gae_flex_metadata]
-module.exports = app;
+export default app;

appengine/metadata/flexible/test/server.test.js

@@ -1,6 +1,19 @@
-const path = require('path');
-const app = require(path.join(__dirname, '../', 'server.js'));
-const supertest = require('supertest');
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+import supertest from 'supertest';
+import app from '../server.js';
 
 describe('gae_flex_metadata', () => {
   it('should be listening', async () => {