More more more codecov coverage improvements

Author: GoodforGod

src/main/java/io/api/etherscan/core/impl/BasicProvider.java

@@ -1,7 +1,7 @@
 package io.api.etherscan.core.impl;
 
 import com.google.gson.Gson;
-import io.api.etherscan.error.NoResponseException;
+import io.api.etherscan.error.EtherScanException;
 import io.api.etherscan.error.ParseException;
 import io.api.etherscan.executor.IHttpExecutor;
 import io.api.etherscan.manager.IQueueManager;
@@ -51,7 +51,7 @@ String getRequest(final String urlParameters) {
         final String url = baseUrl + module + urlParameters;
         final String result = executor.get(url);
         if (BasicUtils.isEmpty(result))
-            throw new NoResponseException("Server returned null value for GET request at URL - " + url);
+            throw new EtherScanException("Server returned null value for GET request at URL - " + url);
 
         return result;
     }

src/main/java/io/api/etherscan/core/impl/ProxyApiProvider.java

@@ -145,9 +145,7 @@ public Optional<String> txSendRaw(final String hexEncodedTx) throws ApiException
             throw new EtherScanException("Error occurred with code " + response.getError().getCode()
                     + " with message " + response.getError().getMessage());
 
-        return (BasicUtils.isEmpty(response.getResult()))
-                ? Optional.empty()
-                : Optional.of(response.getResult());
+        return Optional.ofNullable(response.getResult());
     }
 
     @NotNull
@@ -169,9 +167,7 @@ public Optional<String> call(final String address, final String data) throws Api
 
         final String urlParams = ACT_CALL_PARAM + TO_PARAM + address + DATA_PARAM + data + TAG_LAST_PARAM;
         final StringProxyTO response = getRequest(urlParams, StringProxyTO.class);
-        return (BasicUtils.isEmpty(response.getResult()))
-                ? Optional.empty()
-                : Optional.of(response.getResult());
+        return Optional.ofNullable (response.getResult());
     }
 
     @NotNull
@@ -181,9 +177,7 @@ public Optional<String> code(final String address) throws ApiException {
 
         final String urlParams = ACT_CODE_PARAM + ADDRESS_PARAM + address + TAG_LAST_PARAM;
         final StringProxyTO response = getRequest(urlParams, StringProxyTO.class);
-        return (BasicUtils.isEmpty(response.getResult()))
-                ? Optional.empty()
-                : Optional.of(response.getResult());
+        return Optional.ofNullable(response.getResult());
     }
 
     @NotNull

src/main/java/io/api/etherscan/error/NoResponseException.java

@@ -34,7 +34,7 @@ public void validKey() {
 
     @Test(expected = ApiKeyException.class)
     public void emptyKey() {
-        new EtherScanApi("", network);
+        new EtherScanApi("");
     }
 
     @Test(expected = ApiKeyException.class)

src/test/java/io/api/etherscan/EtherScanApiTest.java

@@ -71,7 +71,15 @@ public void invalidParamWithError() {
         addresses.add("0x9327cb34984c3992ec1EA0eAE98Ccf80A74f95B9");
         addresses.add("C9F32CE1127e44C51cbD182D6364F3D707Fd0d47");
 
+        api.account().balances(addresses);
+    }
+
+    @Test
+    public void emptyParamList() {
+        List<String> addresses = new ArrayList<>();
         List<Balance> balances = api.account().balances(addresses);
+        assertNotNull(balances);
+        assertTrue(balances.isEmpty());
     }
 
     @Test

src/test/java/io/api/etherscan/account/AccountBalanceListTest.java

@@ -11,7 +11,6 @@
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.math.BigInteger;
 import java.util.Arrays;
 import java.util.Collection;
 
@@ -93,10 +92,6 @@ public void correct() {
         assertNotEquals(0, balance.getWei());
         assertNotNull(balance.toString());
 
-        TokenBalance balance1 = new TokenBalance("", BigInteger.ONE, "");
-        assertNotEquals(balance, balance1);
-        assertNotEquals(balance.hashCode(), balance1.hashCode());
-
         TokenBalance balance2 = new TokenBalance("125161", balance.getWei(), balance.getContract());
         assertNotEquals(balance, balance2);
         assertNotEquals(balance.hashCode(), balance2.hashCode());

src/test/java/io/api/etherscan/account/AccountTokenBalanceTest.java

@@ -2,7 +2,6 @@
 
 import com.google.gson.Gson;
 import io.api.etherscan.error.EtherScanException;
-import io.api.etherscan.error.NoResponseException;
 import io.api.etherscan.error.ParseException;
 import io.api.etherscan.model.utility.StringResponseTO;
 import org.junit.Assert;
@@ -101,9 +100,4 @@ public void isResponseNullThrows() {
     public void isThrowParseException() {
         throw new ParseException("Test", null);
     }
-
-    @Test(expected = NoResponseException.class)
-    public void isThrowNoResponseException() {
-        throw new NoResponseException("Test");
-    }
 }