remove remaining build references

Author: fbourigault

UPGRADE.md

@@ -37,6 +37,7 @@ Use the `deployKeys`, `deployKey`, `addDeployKey`, `deleteDeployKey`, `removeDep
 ## `Gitlab\Api\Repositories` changes
 
 * The `commits` page argument now start from 1 instead of 0.
+* The `commitBuilds` method have been removed. Use `Gitlab\Api\Projects::pipelines` instead.
 
 ## `Gitlab\Model\Project` changes
 

lib/Gitlab/Api/Projects.php

@@ -148,12 +148,45 @@ public function unarchive($project_id){
     }
 
     /**
-     * @param int $project_id
+     * @param int   $project_id
+     * @param array $parameters (
+     *
+     *     @var string $scope       The scope of pipelines, one of: running, pending, finished, branches, tags.
+     *     @var string $status      The status of pipelines, one of: running, pending, success, failed, canceled, skipped.
+     *     @var string $ref         The ref of pipelines.
+     *     @var bool   $yaml_errors Returns pipelines with invalid configurations.
+     *     @var string $name        The name of the user who triggered pipelines.
+     *     @var string $username    The username of the user who triggered pipelines.
+     *     @var string $order_by    Order pipelines by id, status, ref, or user_id (default: id).
+     *     @var string $order       Sort pipelines in asc or desc order (default: desc).
+     * )
      * @return mixed
      */
-    public function pipelines($project_id)
+    public function pipelines($project_id, array $parameters = [])
     {
-        return $this->get($this->getProjectPath($project_id, 'pipelines'));
+        $resolver = $this->createOptionsResolver();
+        $booleanNormalizer = function ($value) {
+            return $value ? 'true' : 'false';
+        };
+
+        $resolver->setDefined('scope')
+            ->setAllowedValues('scope', ['running', 'pending', 'finished', 'branches', 'tags'])
+        ;
+        $resolver->setDefined('status')
+            ->setAllowedValues('status', ['running', 'pending', 'success', 'failed', 'canceled', 'skipped'])
+        ;
+        $resolver->setDefined('ref');
+        $resolver->setDefined('yaml_errors')
+            ->setAllowedTypes('yaml_errors', 'bool')
+            ->setNormalizer('yaml_errors', $booleanNormalizer)
+        ;
+        $resolver->setDefined('name');
+        $resolver->setDefined('username');
+        $resolver->setDefined('order_by')
+            ->setAllowedValues('order_by', ['id', 'status', 'ref', 'user_id'])
+        ;
+
+        return $this->get($this->getProjectPath($project_id, 'pipelines'), $resolver->resolve($parameters));
     }
 
     /**

lib/Gitlab/Api/Repositories.php

@@ -125,24 +125,6 @@ public function updateRelease( $project_id, $tag_name, $description ) {
         ) );
     }
 
-    /**
-     * @param int $project_id
-     * @param string $sha
-     * @param string $scope
-     * @param int $page
-     * @param int $per_page
-     *
-     * @return mixed
-     */
-    public function commitBuilds($project_id, $sha, $scope = null, $page = 0, $per_page = self::PER_PAGE)
-    {
-        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.$this->encodePath($sha).'/builds'), array(
-            'page' => $page,
-            'per_page' => $per_page,
-            'scope' => $scope
-        ));
-    }
-
     /**
      * @param int $project_id
      * @param int $page

lib/Gitlab/Model/ProjectHook.php

@@ -11,7 +11,7 @@
  * @property-read bool $push_events
  * @property-read bool $issues_events
  * @property-read bool $merge_requests_events
- * @property-read bool $build_events
+ * @property-read bool $job_events
  * @property-read bool $tag_push_events
  * @property-read string $created_at
  * @property-read Project $project
@@ -29,7 +29,7 @@ class ProjectHook extends AbstractModel
         'push_events',
         'issues_events',
         'merge_requests_events',
-        'build_events',
+        'job_events',
         'tag_push_events',
         'created_at'
     );

test/Gitlab/Tests/Api/RepositoriesTest.php

@@ -235,46 +235,6 @@ public function shouldGetCommits()
         $this->assertEquals($expectedArray, $api->commits(1));
     }
 
-    /**
-     * @test
-     */
-    public function shouldGetCommitBuilds()
-    {
-        $expectedArray = array(
-            array('id' => 'abcd1234', 'status' => 'failed'),
-            array('id' => 'efgh5678', 'status' => 'success')
-        );
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('projects/1/repository/commits/abcd12345/builds', array('page' => 0, 'per_page' => AbstractApi::PER_PAGE, 'scope' => null))
-            ->will($this->returnValue($expectedArray))
-        ;
-
-        $this->assertEquals($expectedArray, $api->commitBuilds(1, 'abcd12345'));
-    }
-
-    /**
-     * @test
-     */
-    public function shouldGetCommitBuildsWithScope()
-    {
-        $expectedArray = array(
-            array('id' => 'abcd1234', 'status' => 'success'),
-        );
-
-        $api = $this->getApiMock();
-        $api->expects($this->once())
-            ->method('get')
-            ->with('projects/1/repository/commits/abcd12345/builds', array('page' => 0, 'per_page' => AbstractApi::PER_PAGE, 'scope' => 'success'))
-            ->will($this->returnValue($expectedArray))
-        ;
-
-        $this->assertEquals($expectedArray, $api->commitBuilds(1, 'abcd12345', 'success'));
-    }
-
-
     /**
      * @test
      */